[Buildroot] [PATCH 04/19] package/x11r7/xdriver_xf86-video-amdgpu: needs libgbm

[Bernd Kuhls]

Hi Thomas,

Am Mon, 6 Jun 2022 00:01:20 +0200 schrieb Thomas Petazzoni via buildroot:

> Could you clarify if this is a fix, or an improvement?

before answering your question I would like to say that the dependency 
situation in package/x11r7/ is a bit messy imho. Fixing autobuilder bugs, 
and there were lots of them in the mesa/x11 area, made sure that we have 
all necessary dependencies in place but, as in this case, we added 
sometimes too many dependencies, did not notice when bumping a package 
that its dependencies were loosened, are, as in this case, did not use 
the new libgbm virtual package in all places needed.

> If I understand correctly the discussion at
> http://lists.busybox.net/pipermail/buildroot/2022-April/641451.html,
> this driver used to require mesa3d+dri+egl (which guaranteed to provide
> libgbm), but now only requires libgbm.

Here we have such a current example for too many dependencies due to the 
addition of the virtual libgbm package which was added to buildroot long 
after this package was added.
Depending on mesa3d+dri+egl did the trick in earlier days ;) Upstream did 
not change its configure script: https://cgit.freedesktop.org/xorg/driver/
xf86-video-amdgpu/log/configure.ac

So this patch series can be considered as a follow-up to the addition of 
libgbm

>>  XDRIVER_XF86_VIDEO_AMDGPU_DEPENDENCIES = \
>>  	libdrm \
>> +	libgbm \
>>  	xlib_libXcomposite \
>>  	xorgproto \ xserver_xorg-server
> 
> Interesting, we had a Config.in dependency on mesa, but it was not a
> build dependency, but libgbm is?

Mesa3d, and therefore libgbm, is pulled in by the xserver_xorg-server 
package, but to make clear this package depends on libgbm I added that 
dependency:
https://gitlab.freedesktop.org/xorg/driver/xf86-video-amdgpu/-/blob/
master/configure.ac#L75

Regards, Bernd