[Buildroot] [PATCH 04/19] package/x11r7/xdriver_xf86-video-amdgpu: needs libgbm

[Thomas Petazzoni]

Hello,

On Sat, 14 May 2022 19:55:57 +0200
Bernd Kuhls <bernd.kuhls at t-online.de> wrote:

> The package depends on gbm:
> https://gitlab.freedesktop.org/xorg/driver/xf86-video-amdgpu/-/blob/master/configure.ac#L75
> 
> For details see
> http://lists.busybox.net/pipermail/buildroot/2022-April/641451.html
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>

Could you clarify if this is a fix, or an improvement?

If I understand correctly the discussion at
http://lists.busybox.net/pipermail/buildroot/2022-April/641451.html,
this driver used to require mesa3d+dri+egl (which guaranteed to provide
libgbm), but now only requires libgbm. If this is correct, then this
patch is not a fix, but an improvement, because it makes this package
available in a larger set of configurations.

Could you clarify this?

> diff --git a/package/x11r7/xdriver_xf86-video-amdgpu/xdriver_xf86-video-amdgpu.mk b/package/x11r7/xdriver_xf86-video-amdgpu/xdriver_xf86-video-amdgpu.mk
> index c34af6faf1..ba4ab43db2 100644
> --- a/package/x11r7/xdriver_xf86-video-amdgpu/xdriver_xf86-video-amdgpu.mk
> +++ b/package/x11r7/xdriver_xf86-video-amdgpu/xdriver_xf86-video-amdgpu.mk
> @@ -11,6 +11,7 @@ XDRIVER_XF86_VIDEO_AMDGPU_LICENSE = MIT
>  XDRIVER_XF86_VIDEO_AMDGPU_LICENSE_FILES = COPYING
>  XDRIVER_XF86_VIDEO_AMDGPU_DEPENDENCIES = \
>  	libdrm \
> +	libgbm \
>  	xlib_libXcomposite \
>  	xorgproto \
>  	xserver_xorg-server

Interesting, we had a Config.in dependency on mesa, but it was not a
build dependency, but libgbm is?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com