[Buildroot] [PATCH 1/1] scanpypi: write every license file once

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Oct 10 07:29:22 UTC 2019


Hello Yegor,

On Wed, 9 Oct 2019 19:36:23 +0200
Yegor Yefremov <yegorslists at googlemail.com> wrote:

> > There are two checks to see if the manual gpio is configured, but
> > these the check is seeing if the structure is NULL instead it
> > should check to see if there are CTS and/or RTS pins defined.
> >
> > This patch uses checks for those individual pins instead of
> > checking for the structure itself to restore auto RTS/CTS.
> >
> > Signed-off-by: Adam Ford <aford173 at gmail.com>  

Is that a bad copy/paste ? It seems like you were working on some
serial port kernel commits at the same time, isn't it ? :-)

> Reviewed-by: Yegor Yefremov <yegorslists at googlemail.com>

Anyway, thanks for the review! :-)

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list