[Buildroot] [PATCH 1/1] scanpypi: write every license file once

Yegor Yefremov yegorslists at googlemail.com
Wed Oct 9 17:36:23 UTC 2019


On Tue, Oct 8, 2019 at 11:22 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello,
>
> +Yegor in Cc.
>
> On Tue,  8 Oct 2019 12:04:04 +0300
> Asaf Kahlon <asafka7 at gmail.com> wrote:
>
> > On some cases, when the package contains multiple license files
> > and some of them from the same type, the scanpypi script will write
> > the same license type more than once under _LICENSE.
> > Hence, before creating the _LICENSE variable, we'll remove every
> > possible duplication.
> >
> > Signed-off-by: Asaf Kahlon <asafka7 at gmail.com>
> > ---
> >  utils/scanpypi | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Yegor, it would be nice to have your review on this patch. Thanks!

On Sun, Oct 6, 2019 at 6:33 PM Adam Ford <aford173 at gmail.com> wrote:
>
> There are two checks to see if the manual gpio is configured, but
> these the check is seeing if the structure is NULL instead it
> should check to see if there are CTS and/or RTS pins defined.
>
> This patch uses checks for those individual pins instead of
> checking for the structure itself to restore auto RTS/CTS.
>
> Signed-off-by: Adam Ford <aford173 at gmail.com>

Reviewed-by: Yegor Yefremov <yegorslists at googlemail.com>



More information about the buildroot mailing list