[Buildroot] [PATCH 1/1] package/libnss: fix musl build

[Fabrice Fontaine]

Fix following musl build failure raised at least since bump to version
3.84 in commit bcdf2fc0e41832147d3fc398070074be29c159d4:

/home/buildroot/autobuild/instance-3/output-1/host/bin/microblazeel-linux-gcc -shared   -Wl,-z,defs -Wl,-soname -Wl,libfreebl3.so  -Wl,--version-script,Linux2.6_microblazeel_microblazeel-linux-gcc.br_real_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/freebl.def -Wl,-Bsymbolic -o Linux2.6_microblazeel_microblazeel-linux-gcc.br_real_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/libfreebl3.so Linux2.6_microblazeel_microblazeel-linux-gcc.br_real_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/lowhash_vector.o      -ldl -lc
/home/buildroot/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/microblazeel-buildroot-linux-musl/11.2.0/../../../../microblazeel-buildroot-linux-musl/bin/ld: Linux2.6_microblazeel_microblazeel-linux-gcc.br_real_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/lowhash_vector.o: in function `loader_GetOriginalPathname':
(.text.loader_GetOriginalPathname+0x1c4): undefined reference to `PR_SetError'

Fixes:
 - http://autobuild.buildroot.org/results/9a51138bb8a65f7f76a01d0e73c451273e6eb49e
 - http://autobuild.buildroot.org/results/d00d22f1bfee5c175f3266ff16124632906463c3

Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
---
 ...l-genload.c-drop-call-to-PR_SetError.patch | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 package/libnss/0002-lib-freebl-genload.c-drop-call-to-PR_SetError.patch

diff --git a/package/libnss/0002-lib-freebl-genload.c-drop-call-to-PR_SetError.patch b/package/libnss/0002-lib-freebl-genload.c-drop-call-to-PR_SetError.patch
new file mode 100644
index 0000000000..fcbb434727
--- /dev/null
+++ b/package/libnss/0002-lib-freebl-genload.c-drop-call-to-PR_SetError.patch
@@ -0,0 +1,39 @@
+From ac93583db67145467c0698f6adba5ee907d9216b Mon Sep 17 00:00:00 2001
+From: Fabrice Fontaine <fontaine.fabrice at gmail.com>
+Date: Fri, 12 Jan 2024 20:13:30 +0100
+Subject: [PATCH] lib/freebl/genload.c: drop call to PR_SetError
+
+Drop call to PR_SetError in genload.c as already done in
+lowhash_vector.c to avoid adding a dependency on a function defined in
+nspr and raising the following build failure when FREEBL_NO_DEPEND is
+set to 1 (default on Linux):
+
+/home/buildroot/autobuild/instance-3/output-1/host/bin/microblazeel-linux-gcc -shared   -Wl,-z,defs -Wl,-soname -Wl,libfreebl3.so  -Wl,--version-script,Linux2.6_microblazeel_microblazeel-linux-gcc.br_real_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/freebl.def -Wl,-Bsymbolic -o Linux2.6_microblazeel_microblazeel-linux-gcc.br_real_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/libfreebl3.so Linux2.6_microblazeel_microblazeel-linux-gcc.br_real_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/lowhash_vector.o      -ldl -lc
+/home/buildroot/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/microblazeel-buildroot-linux-musl/11.2.0/../../../../microblazeel-buildroot-linux-musl/bin/ld: Linux2.6_microblazeel_microblazeel-linux-gcc.br_real_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/lowhash_vector.o: in function `loader_GetOriginalPathname':
+(.text.loader_GetOriginalPathname+0x1c4): undefined reference to `PR_SetError'
+
+Fixes:
+ - http://autobuild.buildroot.org/results/d00d22f1bfee5c175f3266ff16124632906463c3
+
+Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
+Upstream: https://github.com/nss-dev/nss/pull/28
+---
+ lib/freebl/genload.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/nss/lib/freebl/genload.c b/nss/lib/freebl/genload.c
+index 832deb58c..1f145048b 100644
+--- a/nss/lib/freebl/genload.c
++++ b/nss/lib/freebl/genload.c
+@@ -43,7 +43,7 @@ loader_GetOriginalPathname(const char* link)
+     PRUint32 iterations = 0;
+     PRInt32 len = 0, retlen = 0;
+     if (!link) {
+-        PR_SetError(PR_INVALID_ARGUMENT_ERROR, 0);
++        /*PR_SetError(PR_INVALID_ARGUMENT_ERROR, 0); */
+         return NULL;
+     }
+     len = PR_MAX(1024, strlen(link) + 1);
+-- 
+2.43.0
+
-- 
2.43.0