[Buildroot] [PATCH] package/iozone: bump to version 3.506

Gilles Talis gilles.talis at gmail.com
Sun Feb 18 11:13:36 UTC 2024


Hi Julien,

Thanks a lot for the review!

Le sam. 17 févr. 2024 à 12:05, Julien Olivain <ju.o at free.fr> a écrit :
>
> Hi Gilles, All,
>
> Thanks for the patch!
>
> I have few comments:
>
> Could you add a reference in commit log to the upstream change log?
> For example:
> """
> For change log, see end of file:
> https://www.iozone.org/src/current/Changes.txt
> """
> This helps a lot for later analyses/debugging.
Yes, did not realize it was added. Will change that.

>
> Also, the upstream archive of this new version seems to include
> the license file. So the comment can be removed, and the license
> file added (see later).
OK. Will change that too.

>
> Finally, could you add a comment in the commit log that:
> The upstream archive format changed from tgz to tar.
> (just to record this is not an arbitrary change).
Well noted. Will also change that.

>
> On 15/02/2024 15:24, Gilles Talis wrote:
> > Signed-off-by: Gilles Talis <gilles.talis at gmail.com>
> > ---
> >  package/iozone/iozone.hash | 2 +-
> >  package/iozone/iozone.mk   | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/package/iozone/iozone.hash b/package/iozone/iozone.hash
> > index 9ecf1d1af8..c506b41db2 100644
> > --- a/package/iozone/iozone.hash
> > +++ b/package/iozone/iozone.hash
> > @@ -1,2 +1,2 @@
> >  # Locally calculated
> > -sha256
> > 5a52f5017e022e737f5b55f320cc6ada0f2a8c831a5f996cce2a44e03e91c038
> > iozone3_493.tgz
> > +sha256
> > 114ce5c071873b9a2c7ba6e73d05d5ef7e66564392acbfcdc0b3261db10fcbe7
> > iozone3_506.tar
>
> The license file hash can be added here:
> sha256  bff7909fd698708d15613a4fb977a193cff98f44ef170c2dc1dd502974df75b2
>   docs/License.txt
>
> > diff --git a/package/iozone/iozone.mk b/package/iozone/iozone.mk
> > index 2df4a2aa84..7cce15c53d 100644
> > --- a/package/iozone/iozone.mk
> > +++ b/package/iozone/iozone.mk
> > @@ -4,8 +4,8 @@
> >  #
> >
> > ################################################################################
> >
> > -IOZONE_VERSION = 3.493
> > -IOZONE_SOURCE = iozone$(subst .,_,$(IOZONE_VERSION)).tgz
> > +IOZONE_VERSION = 3.506
> > +IOZONE_SOURCE = iozone$(subst .,_,$(IOZONE_VERSION)).tar
> >  IOZONE_SITE = http://www.iozone.org/src/current
> >  IOZONE_LICENSE = IOzone license (NO DERIVED WORKS ALLOWED)
> >  # IOzone license details can be found at:
>
> The license comment can be removed here, and the license file added:
> IOZONE_LICENSE_FILES = docs/License.txt
>
> > --
> > 2.39.2
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> Best regards,
>
> Julien.
thanks
Gilles.



More information about the buildroot mailing list