[Buildroot] [PATCH 21/21] boot/ti-k3-image-gen: remove package

[Romain Naour]

Hi Alexander,

Le 15/02/2024 à 19:50, Alexander Sverdlin a écrit :
> Hi Romain,
> 
> On Thu, 2024-02-15 at 12:26 +0100, Romain Naour wrote:
>>> On Tue, 2024-02-13 at 18:28 +0100, Romain Naour wrote:
>>>> -choice
>>>> -	prompt "Security type"
>>>> -	help
>>>> -	  The target SoC security type option for image gen.  Valid
>>>> -	  options are "gp" for General Purpose devices, "hs-fs" for
>>>> -	  High Security - Field Securable devices, or "hs" for High
>>>> -	  Security - Security Enforcing devices.  Note for all High
>>>> -	  Security device variants the TI_SECURE_DEV_PKG environmental
>>>> -	  variable must be defined at build time pointing to a valid
>>>> -	  core-secdev-k3 folder location, otherwise the build will
>>>> -	  fail, see
>>>> -	  https://git.ti.com/cgit/security-development-tools/core-secdev-k3
>>>> -
>>>> -config BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_GP
>>>> -	bool "gp"
>>>> -
>>>> -config BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_HS_FS
>>>> -	bool "hs-fs"
>>>> -
>>>> -config BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_HS
>>>> -	bool "hs"
>>>> -
>>>> -endchoice
>>>
>>> another observation I made just now: previously BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_GP=y
>>> was the default, which didn't boot on my HS-FS SoC.
>>>
>>> You patchset started out-of-the-box, which, I conclude, means, HS-FS is now the
>>> default for AM62x. I'm not sure if this is a problem, though.
>>>
>>
>> I don't think so, the am62x defconfig should still be for GP SoC by default.
> 
> I'm pretty sure it's HS-FS by default, because GP (as of todays "master")
> 
>>>> ti-k3-image-gen 08.06.00.007 Extracting
> gzip -d -c /home/alex/remote/buildroot/dl/ti-k3-image-gen/k3-image-gen-08.06.00.007.tar.gz | /home/alex/remote/buildroot/output/host/bin/tar --strip-components=1 -C
> /home/alex/remote/buildroot/output/build/ti-k3-image-gen-08.06.00.007   -xf -
>>>> ti-k3-image-gen 08.06.00.007 Patching
>>>> ti-k3-image-gen 08.06.00.007 Configuring
> cp /home/alex/remote/buildroot/output/images/ti-sysfw/ti-fs-firmware-am62x-hs-fs.bin /home/alex/remote/buildroot/output/build/ti-k3-image-gen-08.06.00.007
> cp: cannot stat '/home/alex/remote/buildroot/output/images/ti-sysfw/ti-fs-firmware-am62x-hs-fs.bin': No such file or directory
> make: *** [package/pkg-generic.mk:273: /home/alex/remote/buildroot/output/build/ti-k3-image-gen-08.06.00.007/.stamp_configured] Error 1

Weird, the gitlab-ci build fine with :

BR2_TARGET_TI_K3_BOOT_FIRMWARE=y
BR2_TARGET_TI_K3_IMAGE_GEN=y
# BR2_TARGET_TI_K3_IMAGE_GEN_SOC_AM62AX is not set
# BR2_TARGET_TI_K3_IMAGE_GEN_SOC_AM62X is not set
BR2_TARGET_TI_K3_IMAGE_GEN_SOC_AM64X=y
# BR2_TARGET_TI_K3_IMAGE_GEN_SOC_AM65X is not set
BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_GP=y
# BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_HS_FS is not set
# BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE_HS is not set
BR2_TARGET_TI_K3_IMAGE_GEN_SOC="am64x"
BR2_TARGET_TI_K3_IMAGE_GEN_FW_TYPE="ti-sci"
BR2_TARGET_TI_K3_IMAGE_GEN_SECTYPE="gp"
BR2_TARGET_TI_K3_R5_LOADER=y
BR2_TARGET_TI_K3_R5_LOADER_LATEST_VERSION=y

AM64x: https://gitlab.com/buildroot.org/buildroot/-/jobs/6134305650

Same for AM62x: https://gitlab.com/buildroot.org/buildroot/-/jobs/6134305619

> 
> So overall, for HS-FS it doesn't look as a regression with you patchset,
> but rather as improvement, even though it doesn't boot, but it builds
> at least...
> 
> I can try to look what could be the problem with U-Boot environment...
> 
Yes please.

Best regards,
Romain