[Buildroot] [PATCH] toolchain/external: remove libcrypt from glibc

Yann E. MORIN yann.morin.1998 at free.fr
Tue Apr 9 20:35:37 UTC 2024


Thomas, All,

On 2024-04-09 21:51 +0200, Thomas Petazzoni spake thusly:
> On Mon,  8 Apr 2024 22:57:42 +0200
> "Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:
> > Note: this commit only deals with glibc and its internal libcrypt (or
> > lack thereof); other C libraries, musl and uClibc-NG, are not considered.
[--SNIP--]
> >  ifeq ($(BR2_TOOLCHAIN_EXTERNAL_GLIBC),y)
> >  TOOLCHAIN_EXTERNAL_LIBS += libnss_files.so.* libnss_dns.so.* libmvec.so.* libanl.so.*
> > +# Note: explicitly do copy libcrypt*.so.* even for glibc: it is not the same
> Are you sure you wanted to say libcrypt*.so.* here? Didn't you want to
> say libcrypt.so.1 ?

Damned, I missed that. Yes, this is about "libcrypt.so.1" explicitly.

> If you wanted to say libcrypt.so.1, then the patch is fine for me and
> you can add my
> 
>   Reviewed-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>

Good, I'll respin.

Regards,
Yann E. MORIN.

> Best regards,
> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list