[Buildroot] [PATCH 1/1] package/libuv: needs gcc >= 4.9

[Arnout Vandecappelle]

On 17/09/2023 21:48, Fabrice Fontaine wrote:
> libuv unconditionally uses stdatomic since
> https://github.com/libuv/libuv/commit/2f33980a9141bd49cb2c34361854355b23b1e6fc
> resulting in the following build failure with gcc < 4.9 since bump to
> version 1.45.0 in commit 21764235cb7f7fb767ea4b5d825e39c711aee235:
> 
> In file included from src/fs-poll.c:23:0:
> src/uv-common.h:41:24: fatal error: stdatomic.h: No such file or directory
>   # include <stdatomic.h>
>                          ^
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/6b9ce25ba7e5c5602313d533f460f8829f767f81
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>

  Applied to master, thanks.

[snip]
> diff --git a/package/cmake/Config.in b/package/cmake/Config.in
> index 4ef5612b57..57b1ebf9fd 100644
> --- a/package/cmake/Config.in
> +++ b/package/cmake/Config.in
> @@ -14,7 +14,7 @@ config BR2_PACKAGE_CMAKE
>   config BR2_PACKAGE_CMAKE_CTEST
>   	bool "ctest"
>   	depends on BR2_PACKAGE_CMAKE_ARCH_SUPPORTS
> -	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # from jsoncpp
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libuv

  Here, I kept jsoncpp in the comment as well. That way, if someone ever removes 
the libuv dependency, they are reminded that jsoncpp also introduces a gcc 
version dependency.

  Note that for nodejs and uvw, the gcc version dependency comes from the 
package itself; there's no way that that version dependency will ever go away, 
so there's no need to track the dependencies.

  Regards,
  Arnout

[snip]