[Buildroot] [External] Re: [PATCH 1/1] ppd-merge: speed up per-package-rsync

[Maier, Brandon L Collins]

Hi Herve, Yann

> [...]
> > > > +   PER_PACKAGE_DIR=$(PER_PACKAGE_DIR) \
> > > > +           $(TOPDIR)/support/scripts/ppd-merge.sh \
> > > > +           $(2) $(3) $(4) $(1)
> > >
> > > What do you think about passing the PER_PACKAGE_DIR by parameter
> > > instead of
> > > mixing environment values and parameters ?
> >
> > I was trying to copy the style of support/scripts/fix-rpath, which takes
> PER_PACKAGE_DIR from the environment. For example, see ./Makefile
> "prepare-sdk:" target.
> >
>
> Makes sense.
> On the other hand, support/scripts/check-host-rpath takes
> PER_PACKAGE_DIR from parameters.
>   https://urldefense.com/v3/__https://gitlab.com/buildroot.org/buildroot/-
> /blob/master/package/pkg-
> generic.mk?ref_type=heads*L62__;Iw!!MvWE!E_uYw1n1D_rdclSbh2DWEtXp
> kOR6peTRWGpvjNiTFyvSz_0PFA-
> zD4uc1xXoqQl0T4Cp_wjJ6O6kYHkOqHoURX7ebRA$
>
> I have no opinion about what is the best to do.
> Maybe Yann ?

And oops, I missed check-host-rpath :). It's a trivial change so I can send a v2 with that if it's preferred.

> Best regards,
> Hervé