[Buildroot] [PATCH 0/1] Regarding review of qbee-agent patch

[Jon Henrik Bjørnstad]

Hi Thomas,

Thanks for the initial review. I've attempted to implement most of the 
feedback.

Some notes on a few items that have been left unchanged:

License file:

The tarball in use does not contain a license file. I'm fairly new to
the buildroot project and have used a lot of existing package implementations
as inspiration. Is a license file required when using a general license 
like Apache 2.0?

Static binaries:

The binaries are statically built with a public part of a signing key
as part of the compile time arguments. This public key is used to verify
downloaded static runtime binaries from the qbee.io SaaS platform which
is signed with the production signing key. Currently only arms and intels
are supported, but this will change with future releases where the
dependency on downloaded static runtime binaries will be removed.

QBEE_AGENT_GOARCH vs. GO_GOARCH:

I changed this due to errors produced by the check-package utility:

With GO_GOARCH:

$ utils/docker-run make check-package
package/qbee-agent/qbee-agent.mk:12: possible typo: GO_GOARCH -> *QBEE_AGENT*
package/qbee-agent/qbee-agent.mk:14: possible typo: GO_GOARCH -> *QBEE_AGENT*
package/qbee-agent/qbee-agent.mk:16: possible typo: GO_GOARCH -> *QBEE_AGENT*
package/qbee-agent/qbee-agent.mk:18: possible typo: GO_GOARCH -> *QBEE_AGENT*


Thank you again for your feedback. 

With kind regards,

Jon Henrik Bjørnstad


Jon Henrik Bjørnstad (1):
  package/qbee-agent: new package

 DEVELOPERS                         |  3 +++
 package/Config.in                  |  1 +
 package/qbee-agent/Config.in       | 17 ++++++++++++
 package/qbee-agent/qbee-agent.hash |  2 ++
 package/qbee-agent/qbee-agent.mk   | 42 ++++++++++++++++++++++++++++++
 5 files changed, 65 insertions(+)
 create mode 100644 package/qbee-agent/Config.in
 create mode 100644 package/qbee-agent/qbee-agent.hash
 create mode 100644 package/qbee-agent/qbee-agent.mk

-- 
2.25.1