[Buildroot] [git commit] package/petitboot: use default logfile dir
Arnout Vandecappelle
arnout at mind.be
Sun Nov 5 17:15:30 UTC 2023
commit: https://git.buildroot.net/buildroot/commit/?id=12e964302174dd299a6ce48fb3f6c349c45dd718
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
All the petitboot components assume /var/log/petitboot by default;
pb-console can also put multiple logs there and pb-sos collects that
directory when creating a diagnostic tarball.
Defer to this default when launching pb-discover. If someone wants to
override, let's call the file /etc/default/petitboot which makes more
sense to be shared by all the components.
Signed-off-by: Reza Arbab <arbab at linux.ibm.com>
Signed-off-by: Arnout Vandecappelle <arnout at mind.be>
---
package/petitboot/S15pb-discover | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/package/petitboot/S15pb-discover b/package/petitboot/S15pb-discover
index 9b641298ca..71ab62d998 100644
--- a/package/petitboot/S15pb-discover
+++ b/package/petitboot/S15pb-discover
@@ -2,12 +2,9 @@
DAEMON="pb-discover"
PIDFILE="/var/run/$DAEMON.pid"
-LOGFILE="/var/log/$DAEMON.log"
-
-PB_DISCOVER_ARGS="-l $LOGFILE"
# shellcheck source=/dev/null
-[ -r "/etc/default/$DAEMON" ] && . "/etc/default/$DAEMON"
+[ -r "/etc/default/petitboot" ] && . "/etc/default/petitboot"
if [ "$(pb-config debug)" = "enabled" ] ; then
PB_DISCOVER_ARGS="$PB_DISCOVER_ARGS --verbose"
@@ -15,6 +12,8 @@ fi
start() {
printf 'Starting %s: ' "$DAEMON"
+ mkdir -p /var/log/petitboot
+
# shellcheck disable=SC2086 # we need the word splitting
start-stop-daemon -S -q -b -m -p "$PIDFILE" -x "/usr/sbin/$DAEMON" \
-- $PB_DISCOVER_ARGS
More information about the buildroot
mailing list