[Buildroot] [RFC PATCH v1 1/2] package/sysdig: bump to version 0.31.4
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Mon Jul 31 20:35:52 UTC 2023
On Mon, 31 Jul 2023 22:18:43 +0200
Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:
> By the way
> -DVALIJSON_INCLUDE=$(BUILD_DIR)/valijson-0.6/include/valijson is truly
> horrible, because if valijson gets updated to another version... like
> it has:
>
> VALIJSON_VERSION = 0.7
>
> then this doesn't work anymore.
>
> It needs to be VALIJSON_SRCDIR.
>
> Curious that we can build sysdig today (I verified, it builds) with
> this mistake. Probably means this option is irrelevant.
(1) There is no build dependency on valijson, so I don't see how it
could be relevant anyway.
(2) There is no reference to VALIJSON_INCLUDE anywhere in the code
base, as far as I can see
This really needs to be cleaned up. Very soon.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
More information about the buildroot
mailing list