[Buildroot] [PATCH v2 2/2] package/transmission: fix gtk dependencies

[Yann E. MORIN]

Bernd, All,

On 2023-07-23 10:31 +0200, Bernd Kuhls spake thusly:
> Buildroot commit 80793107a65d95f8dfd0317a726d3a737c78ef67 forgot to add
> packages needed for gtk support:
> https://github.com/transmission/transmission/blob/main/CMakeLists.txt#L40
> 
> Signed-off-by: Bernd Kuhls <bernd at kuhls.net>
> ---
> v2: removed unneeded glibmm, added gtkmm3 dependencies (Thomas)
> 
>  package/transmission/Config.in       | 8 +++++++-
>  package/transmission/transmission.mk | 2 +-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/package/transmission/Config.in b/package/transmission/Config.in
> index fd4c897497..7ac18ae6d9 100644
> --- a/package/transmission/Config.in
> +++ b/package/transmission/Config.in
> @@ -37,11 +37,17 @@ config BR2_PACKAGE_TRANSMISSION_DAEMON
>  
>  config BR2_PACKAGE_TRANSMISSION_GTK
>  	bool "transmission-gtk"
> +	depends on !BR2_nios2 # gtkmm3
> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pangomm, libgtk3 -> pango -> harfbuzz -> gtkmm3
> +	depends on BR2_INSTALL_LIBSTDCPP # glibmm, libpangomm -> glibmm/pango -> gtkmm3
> +	depends on BR2_USE_WCHAR # *mm/libgtk3 -> libglib2 -> gtkmm3

C++ and xide-char are alrady dependencies of transmission, so no need to
replicate them here (yeah, the rule is fuzzy and unwritten, and there is
historical baggage where they are replicated).

>  	depends on BR2_PACKAGE_LIBGTK3 && BR2_SYSTEM_ENABLE_NLS
> +	select BR2_PACKAGE_GTKMM3
>  	help
>  	  Install transmission GTK-based GUI interface.
>  
> -comment "transmission-gtk needs NLS enabled"
> +comment "transmission-gtk needs libgtk3 and a toolchain with NLS enabled"
> +	depends on !BR2_nios2
>  	depends on BR2_PACKAGE_LIBGTK3 && !BR2_SYSTEM_ENABLE_NLS

Still, the sync-4 dependency is missing here, no?

Applied to master with the above changes, thanks.

Regards,
Yann E. MORIN.

>  endif
>  
> diff --git a/package/transmission/transmission.mk b/package/transmission/transmission.mk
> index f3a200ced3..26deeefa34 100644
> --- a/package/transmission/transmission.mk
> +++ b/package/transmission/transmission.mk
> @@ -74,7 +74,7 @@ endif
>  
>  ifeq ($(BR2_PACKAGE_TRANSMISSION_GTK),y)
>  TRANSMISSION_CONF_OPTS += -DENABLE_GTK=ON
> -TRANSMISSION_DEPENDENCIES += libgtk3
> +TRANSMISSION_DEPENDENCIES += gtkmm3 libgtk3
>  else
>  TRANSMISSION_CONF_OPTS += -DENABLE_GTK=OFF
>  endif
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'