[Buildroot] [PATCH] configs: asus_tinker-s_rk3288: new config for the "S" variant of the Tinkerboard

[Giulio Benetti]

Hi Flávio,

On 09/07/23 04:45, Flávio Tapajós wrote:
> This commit duplicates the asus_tinker_rk3288_defconfig changing:
> 
>    - BR2_LINUX_KERNEL_INTREE_DTS_NAME to rk3288-tinker-s
>    - BR2_TARGET_UBOOT_BOARD_DEFCONFIG to tinker-s-rk3288
>    - extlinux.conf devicetree to /boot/rk3288-tinker-s.dtb
>    - root device format to <major>:<minor> in order to prevent the kernel to mount rootfs
>      from the wrong device
> 
> Signed-off-by: Flávio Tapajós <flavio.tapajos at newtesc.com.br>
> ---
>   board/asus/tinker-s/extlinux.conf      |  4 +++
>   board/asus/tinker-s/post-build.sh      |  9 +++++
>   board/asus/tinker-s/readme.txt         | 43 ++++++++++++++++++++++++
>   configs/asus_tinker-s_rk3288_defconfig | 46 ++++++++++++++++++++++++++
>   4 files changed, 102 insertions(+)
>   create mode 100644 board/asus/tinker-s/extlinux.conf
>   create mode 100755 board/asus/tinker-s/post-build.sh
>   create mode 100644 board/asus/tinker-s/readme.txt
>   create mode 100644 configs/asus_tinker-s_rk3288_defconfig
> 
> diff --git a/board/asus/tinker-s/extlinux.conf b/board/asus/tinker-s/extlinux.conf
> new file mode 100644
> index 0000000000..5a2d05b811
> --- /dev/null
> +++ b/board/asus/tinker-s/extlinux.conf
> @@ -0,0 +1,4 @@
> +label Tinker linux
> +  kernel /boot/uImage
> +  devicetree /boot/rk3288-tinker-s.dtb
> +  append console=ttyS2,115200n8 root=179:1 rootwait
> diff --git a/board/asus/tinker-s/post-build.sh b/board/asus/tinker-s/post-build.sh
> new file mode 100755
> index 0000000000..ffbbcdeb58
> --- /dev/null
> +++ b/board/asus/tinker-s/post-build.sh
> @@ -0,0 +1,9 @@
> +#!/bin/sh
> +
> +MKIMAGE=$HOST_DIR/bin/mkimage
> +BOARD_DIR="$(dirname $0)"
> +
> +$MKIMAGE -n rk3288 -T rksd -d $BINARIES_DIR/u-boot-tpl.bin $BINARIES_DIR/u-boot-tpl.img
> +cat $BINARIES_DIR/u-boot-tpl.img $BINARIES_DIR/u-boot-spl-dtb.bin > $BINARIES_DIR/u-boot-tpl-spl-dtb.img
> +
> +install -m 0644 -D $BOARD_DIR/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
> diff --git a/board/asus/tinker-s/readme.txt b/board/asus/tinker-s/readme.txt
> new file mode 100644
> index 0000000000..3dffa12b45
> --- /dev/null
> +++ b/board/asus/tinker-s/readme.txt
> @@ -0,0 +1,43 @@
> +Tinker S RK3288
> +=============
> +
> +Tinker Board is a Single Board Computer (SBC) in an ultra-small form
> +factor that offers class-leading performance while leveraging outstanding
> +mechanical compatibility. The "S" variant of the Tinker Board has eMMC
> +
> +Tinker link:
> +https://www.asus.com/br/motherboards-components/single-board-computer/all-series/tinker-board-s/
> +
> +Wiki link:
> +https://openedev.amarulasolutions.com/display/ODWIKI/Tinker+RK3288
> +
> +How to build it
> +===============
> +
> +  $ make asus_tinker-s_rk3288_defconfig
> +
> +Then you can edit the build options using
> +
> +  $ make menuconfig
> +
> +Compile all and build rootfs image:
> +
> +  $ make
> +
> +Prepare your SDCard
> +===================
> +
> +Buildroot generates a ready-to-use SD card image that you can flash directly to
> +the card. The image will be in output/images/sdcard.img.
> +You can write this image directly to an SD card device (i.e. /dev/xxx):
> +
> +  $ sudo dd if=output/images/sdcard.img of=/dev/xxx
> +  $ sudo sync
> +
> +Finally, you can insert the SD card to the Tinker RK3288 board and boot it.
> +
> +NOTE:
> +USB power supply requires more than the standard 500mA USB current, so
> +this board must be supplied from a capable port or from an external
> +AC/DC adapter. Otherwise it will hang forever while loading the kernel
> +image.
> diff --git a/configs/asus_tinker-s_rk3288_defconfig b/configs/asus_tinker-s_rk3288_defconfig
> new file mode 100644
> index 0000000000..291333f2da
> --- /dev/null
> +++ b/configs/asus_tinker-s_rk3288_defconfig
> @@ -0,0 +1,46 @@
> +# Architecture
> +BR2_arm=y
> +BR2_cortex_a17=y
> +BR2_ARM_FPU_NEON_VFPV4=y
> +
> +# Linux headers same as kernel, a 6.1 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
> +
> +# Bootloader
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10"

could you give a try with latest uboot 2023.04?

> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="tinker-s-rk3288"
> +BR2_TARGET_UBOOT_NEEDS_DTC=y
> +BR2_TARGET_UBOOT_NEEDS_PYTHON3=y
> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> +BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
> +BR2_TARGET_UBOOT_SPL=y
> +BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin tpl/u-boot-tpl.bin"
> +
> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.2"

please use latest stable linux 6.1.38 and test it with uboot latest
stable version

> +BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
> +BR2_LINUX_KERNEL_UIMAGE=y
> +BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-tinker-s"
> +BR2_LINUX_KERNEL_INSTALL_TARGET=y
> +
> +# Filesystem
> +BR2_TARGET_GENERIC_HOSTNAME="tinker-rk3288-s"
> +BR2_TARGET_GENERIC_ISSUE="Welcome to TINKER S RK3288!"
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="512M"
> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y
> +BR2_PACKAGE_HOST_UBOOT_TOOLS=y
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/asus/tinker/genimage.cfg"
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/asus/tinker-s/post-build.sh"

please add an entry to DEVELOPERS file pointing you as maintainer of
this board.

Thank you!
Best regards
-- 
Giulio Benetti
CEO&CTO at Benetti Engineering sas