[Buildroot] [PATCH 1/1] package/libnatpmp: fix header install
Yann E. MORIN
yann.morin.1998 at free.fr
Mon Jul 3 20:30:26 UTC 2023
Bernd, All,
On 2023-07-03 22:20 +0200, Bernd Kuhls spake thusly:
> Upstream renamed declspec.h to natpmp_declspec.h
> https://github.com/miniupnp/libnatpmp/commit/1d113363980a98a5868ff2c2b05d7c94e3a18a70
>
> Signed-off-by: Bernd Kuhls <bernd at kuhls.net>
Applied to master, thanks. But see a question, below...
> ---
> package/libnatpmp/libnatpmp.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libnatpmp/libnatpmp.mk b/package/libnatpmp/libnatpmp.mk
> index 3a625ea0fe..99d46d814a 100644
> --- a/package/libnatpmp/libnatpmp.mk
> +++ b/package/libnatpmp/libnatpmp.mk
> @@ -18,7 +18,7 @@ endef
> define LIBNATPMP_INSTALL_STAGING_CMDS
> $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
> PREFIX=$(STAGING_DIR) \
> - HEADERS='declspec.h natpmp.h' \
> + HEADERS='natpmp_declspec.h natpmp.h' \
So it means 0e258b6190a5 (package/libnatpmp: bump version to 20230423)
was not build-tested before being submitted? At least transmission
unonditionally uses it, so a runtime test of transmission would catch
it.
Regards,
Yann E. MORIN.
> $(TARGET_CONFIGURE_OPTS) install
> endef
>
> --
> 2.39.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list