[Buildroot] [External] Re: [PATCH 1/1] utils/docker-run: fix support for git-worktrees

[Maier, Brandon L Collins]

Yann,

> -----Original Message-----
> From: Yann E. MORIN <yann.morin.1998 at free.fr>

> > +    # Support git-worktree
> > +    GIT_DIR="$(cd "$MAIN_DIR" && readlink -f "$(git rev-parse --git-
> common-dir)")"
>                       ^^^^^^^^^
> Expansion should use curly braces, like everywhere else.
>
> --git-common-dir was only introduced in git 2.10.0, which is most
> probably not available in enterprise-grade distros like RHEL (RHEL 7 is
> still maintained, and it is based on Fedora 19; there's only a docker
> image for Fedora 20, and that has git 1.9).
>
> So I've added --no-flags, that has been present since at least 1.0.0,
> which means that, on git versions that did not support worktrees, we'll
> get an empty GIT_DIR, so that's OK: it means we're in the main working
> copy, and thus we don't need the mount.
>
> Applied to master with those changes, thanks.

All the changes look good to me, and verified still works on my end.

Thanks,
Brandon