[Buildroot] [PATCH 1/1] package/rust-bindgen: new host package

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Jul 3 20:41:49 UTC 2023


Hello Sebastian, Hello Romain,

On Thu,  8 Jun 2023 10:50:15 +0200
Sebastian Weyer <sebastian.weyer at smile.fr> wrote:

> +#When updating to a version >0.63.0, pay attention to the command line
> +#arguments --blacklist* and --whitelist* which are deprecated from 0.63.0
> +#onwards but are still used when compiling the Linux Kernel as of the time
> +#of this comment
> +RUST_BINDGEN_VERSION = 0.65.1

The comment above this version variable is confusing: it says to be
careful when updating to a version >0.63.0, but the patch already
includes a version greater than 0.63.0. So?

Also: space after # sign in comments.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com



More information about the buildroot mailing list