[Buildroot] [PATCH v4 4/4] package/libgtk3: fix update-icon-cache on empty directory
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Sat Feb 25 09:52:10 UTC 2023
Hello Thomas,
On Thu, 23 Feb 2023 13:56:12 +0100
Thomas Devoogdt <thomas at devoogdt.com> wrote:
> If both, hicolor-icon-theme (selected by libgtk3-demo) and
> adwaita-icon-theme is not selected, then the /usr/share/icons
> folder is empty, causing find to fail.
>
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt at barco.com>
Thanks for this work on gtk!
Could you please always resend complete series, even if only one patch
is changed? Otherwise, it's super confusing. We see just PATCH 4/4 in
version 4, and we wonder if the other patches (1/4, 2/4, 3/4) were lost.
> @@ -146,6 +146,7 @@ endef
> # Create icon-theme.cache for each of the icon directories/themes
> # It's not strictly necessary but speeds up lookups
> define LIBGTK3_UPDATE_ICON_CACHE
> +[ ! -d $(TARGET_DIR)/usr/share/icons ] || \
Indentation is not correct, this line should be indented with one tab.
> find $(TARGET_DIR)/usr/share/icons -maxdepth 1 -mindepth 1 -type d \
> -exec $(HOST_DIR)/bin/gtk-update-icon-cache {} \;
> endef
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
More information about the buildroot
mailing list