[Buildroot] [PATCH] package/swugenerator: add missing dependencies

[Giulio Benetti]

Hello Thomas,

On 24/12/23 12:11, Thomas Petazzoni wrote:
> Hello Giulio,
> 
> On Sat,  2 Dec 2023 02:51:23 +0100
> Giulio Benetti <giulio.benetti at benettiengineering.com> wrote:
> 
>> From: Giulio Benetti <giulio.benetti+tekvox at benettiengineering.com>
>>
>> At the moment swugenerator package lacks host-openssl, host-gzip and
>> host-zstd. All their final executables like openssl, gzip and zstd
>> can be used by swugenerator if the correct flag is passed so let's
>> add these missing dependencies.
> 
> Could you clarify whether these are runtime dependencies? If there are
> build time dependencies, do we see build failures in the autobuilders?

I haven't thought about it. They are runtime dependencies, so we can't
see failure in the autobuilders.

>> diff --git a/package/swugenerator/swugenerator.mk b/package/swugenerator/swugenerator.mk
>> index f4ead1d229..141a6a96c5 100644
>> --- a/package/swugenerator/swugenerator.mk
>> +++ b/package/swugenerator/swugenerator.mk
>> @@ -9,6 +9,6 @@ SWUGENERATOR_SITE = $(call github,sbabic,swugenerator,v$(SWUGENERATOR_VERSION))
>>   SWUGENERATOR_LICENSE = GPL-3.0
>>   SWUGENERATOR_LICENSE_FILES = LICENSE
>>   HOST_SWUGENERATOR_SETUP_TYPE = setuptools
>> -HOST_SWUGENERATOR_DEPENDENCIES = host-python-libconf
>> +HOST_SWUGENERATOR_DEPENDENCIES = host-gzip host-openssl host-python-libconf
> 
> In your commit log, you mention host-zstd being needed, but you don't
> add it to the dependencies here. Could you clarify this as well?

Ah right, I simply need to add host-zstd because swugenerator can use
gzip or zstd at runtime.

Thank you for reviewing.

Best regards
-- 
Giulio Benetti
CEO&CTO at Benetti Engineering sas