[Buildroot] [PATCH 1/1] package/octave: add libreadline search prefix

[Thomas Petazzoni]

Hello Julien,

On Tue, 12 Dec 2023 22:46:10 +0100
Julien Olivain <ju.o at free.fr> wrote:

> Since commit b36e4b10f3 "package/octave: bump to version 8.1.0",
> Octave fails to find readline automatically if octave and readline
> packages are both enabled in Buildroot the configuration.
> 
> The readline search prefix need to be explicitly passed during octave
> configuration. This commit adds this search prefix to fix this build
> issue.
> 
> Fixes:
> 
>     checking for readline... (cached) no
>     checking for readline/readline.h... (cached) yes
>     checking for readline/history.h... (cached) yes
>     configure: WARNING: I need GNU Readline 4.2 or later
>     configure: error: this is fatal unless you specify --disable-readline
> 
> Signed-off-by: Julien Olivain <ju.o at free.fr>

This looked good and relevant, but I'm unable to reproduce the issue,
which probably means there is something more to this.

Build:

BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_OCTAVE=y
BR2_PACKAGE_READLINE=y
# BR2_TARGET_ROOTFS_TAR is not set

with:

./utils/docker-run make octave

and it builds just fine, readline is properly detected as it should be.

For the sake of completeness, I also re-did this build on commit
b36e4b10f3, which is when Octave was bumped to 8.1.0, which you said
was the commit that introduced the issue. But it also builds fine.

Could you double check what was your failing configuration, maybe
investigate what is different to understand the root cause?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com