[Buildroot] [PATCH 1/1] package/postgresql: bump version to 16.1

[Maxim Kochetkov]

On 23.12.2023 20:39, Thomas Petazzoni via buildroot wrote:
> On Tue, 19 Dec 2023 10:53:52 +0300
> Maxim Kochetkov via buildroot <buildroot at buildroot.org> wrote:
> 
>> +ifeq ($(BR2_PACKAGE_ICU),y)
>> +POSTGRESQL_DEPENDENCIES += icu
>> +POSTGRESQL_CONF_OPTS += --with-icu
>> +else
>> +POSTGRESQL_CONF_OPTS += --without-icu
>> +endif
> 
> Unless I'm wrong, this change is unrelated to the bump to 16.1. The

https://www.postgresql.org/docs/release/16.0/

.....
Build ICU support by default (Jeff Davis)

This removes build flag --with-icu and adds flag --without-icu.
.....


There will be configure error if ICU is not available:
....
checking for icu-uc icu-i18n... no
configure: error: ICU library not found
If you have ICU already installed, see config.log for details on the
failure.  It is possible the compiler isn't looking in the proper directory.
Use --without-icu to disable ICU support.
....

So we have to provide --without-icu or add ICU dependency

> --with-icu/--without-icu options already exist in the currently
> packaged version of Postgresql in Buildroot. Therefore, could you split

I see no such options in the current package/postgresql.

> this into two patches?

Correct bump is not possible without ifeq ($(BR2_PACKAGE_ICU),y)

> 
> Thanks a lot,
> 
> Thomas