[Buildroot] [PATCH v2] package/swupdate: bump version to 2023.12
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Sat Dec 23 17:43:09 UTC 2023
Hello,
On Mon, 18 Dec 2023 23:47:47 +0100
Giulio Benetti <giulio.benetti at benettiengineering.com> wrote:
> * make json-c mandatory according to [0]
> * make libubootenv mandatory according to [1]
> * drop local patch that has been upstreamed [2]
> * libconfig is not mandatory anymore if no lua parser is enabled
> * adjust Config.in comment according to json-c and libubootenv
>
> [0]: https://github.com/sbabic/swupdate/commit/82e75322443e021d119a026a3476c410f4705d67
> [1]: https://github.com/sbabic/swupdate/commit/75838874e2575f822ed85d89532f47e9adf781b6
> [2]: https://github.com/sbabic/swupdate/commit/1999685830d6e9b57014666b9e53e46de17a471c
>
> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
Thanks for the extensive commit log. I applied with one fix, see below.
> diff --git a/package/swupdate/Config.in b/package/swupdate/Config.in
> index 7d9fc90e10..171805bea9 100644
> --- a/package/swupdate/Config.in
> +++ b/package/swupdate/Config.in
> @@ -3,9 +3,9 @@ config BR2_PACKAGE_SWUPDATE
> depends on !BR2_STATIC_LIBS
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_USE_MMU # fork()
> - # swupdate requires a parser and uses libconfig as default
> - select BR2_PACKAGE_LIBCONFIG if !BR2_PACKAGE_JSON_C && \
> - !BR2_PACKAGE_HAS_LUAINTERPRETER
> + depends on BR2_TOOLCHAIN_HAS_SYNC_4 # json-c
You forgot to replicate this dependency in the Config.in comment of
swupdate, i.e:
comment "swupdate needs a toolchain w/ dynamic library, threads"
depends on BR2_USE_MMU
+ depends on BR2_TOOLCHAIN_HAS_SYNC_4
depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
I fixed that when applying. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
More information about the buildroot
mailing list