[Buildroot] [PATCH 1/1] package/memtest86: pass TARGET_CC

[Fabrice Fontaine]

Le ven. 8 déc. 2023 à 23:54, Yann E. MORIN <yann.morin.1998 at free.fr> a écrit :
>
> On 2023-12-07 23:09 +0100, Fabrice Fontaine spake thusly:
> > Pass CC=$(TARGET_CC) to make to avoid the following build failure raised
> > since bump to version 6.20 in commit
> > a743087593a5fd5b33e2650591cada09929c27a6:
> >
> > gcc -m32 -x assembler-with-cpp -c -I../boot -o boot/startup.o ../boot/startup32.S
> > gcc: error: unrecognized command-line option '-m32'
> >
> > Fixes:
> >  - http://autobuild.buildroot.org/results/15ece19703bb21c1326ff353aa79f3550a01f648
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> > ---
> >  package/memtest86/memtest86.mk | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/memtest86/memtest86.mk b/package/memtest86/memtest86.mk
> > index c0f85755fe..51d5805e0a 100644
> > --- a/package/memtest86/memtest86.mk
> > +++ b/package/memtest86/memtest86.mk
> > @@ -20,7 +20,8 @@ endif
> >  endif
> >
> >  define MEMTEST86_BUILD_CMDS
> > -     $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/$(MEMTEST86_BUILD_DIR)
> > +     $(TARGET_CONFIGURE_OPTS) $(MAKE) CC=$(TARGET_CC) \
>
> CC=$(TARGET_CC) is already present in TARGET_CONFIGURE_OPTS, so why is
> it not accounted for?

Because "CC=$(TARGET_CC) make" is not the same as "make
CC=$(TARGET_CC)" as build{32,64}/Makefile is setting CC to gcc.

>
> Regards,
> Yann E. MORIN.
>
> > +             -C $(@D)/$(MEMTEST86_BUILD_DIR)
> >  endef
> >
> >  define MEMTEST86_INSTALL_IMAGES_CMDS
> > --
> > 2.42.0
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'

Best Regards,

Fabrice