[Buildroot] [PATCH 1/1] package/libselinux: fix build with BR2_TIME_BITS_64

[Fabrice Fontaine]

Hi,

Le ven. 1 déc. 2023 à 21:29, Peter Korsgaard <peter at korsgaard.com> a écrit :

> >>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice at gmail.com> writes:
>
>  > Do not remove _FILE_OFFSET_BITS=64 from CFLAGS and CPPFLAGS to avoid the
>  > following build failure with BR2_TIME_BITS_64 raised since commit
>  > 3c427c64726560ea1743282a3fdb78f5b28692eb:
>
>  > In file included from
> /home/autobuild/autobuild/instance-9/output-1/per-package/libselinux/host/mipsel-buildroot-linux-gnu/sysroot/usr/include/features.h:394,
>  >                  from
> /home/autobuild/autobuild/instance-9/output-1/per-package/libselinux/host/mipsel-buildroot-linux-gnu/sysroot/usr/include/bits/libc-header-start.h:33,
>  >                  from
> /home/autobuild/autobuild/instance-9/output-1/per-package/libselinux/host/mipsel-buildroot-linux-gnu/sysroot/usr/include/stdint.h:26,
>  >                  from
> /home/autobuild/autobuild/instance-9/output-1/per-package/libselinux/host/lib/gcc/mipsel-buildroot-linux-gnu/12.3.0/include/stdint.h:9,
>  >                  from ../include/selinux/avc.h:9,
>  >                  from avc.c:10:
>  >
> /home/autobuild/autobuild/instance-9/output-1/per-package/libselinux/host/mipsel-buildroot-linux-gnu/sysroot/usr/include/features-time64.h:26:5:
> error: #error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
>  >    26 | #   error "_TIME_BITS=64 is allowed only with
> _FILE_OFFSET_BITS=64"
>  >       |     ^~~~~
>
>  > This LFS workaround for glibc < 2.23 was added in 2016 by commit
>  > ebcca24c953d8df4b16bc52c5ba31feae4ed8ad0 and is probably not needed
>  > anymore as glibc 2.23 was released in February 2016:
>  > https://sourceware.org/glibc/wiki/Release/2.23
>
>  > Fixes:
>  >  -
> http://autobuild.buildroot.org/results/d85c81f87adf3a5945fa369bcec233e6def2ed12
>
> Hmm, probably. We do have similar code elsewhere as well though,
> presumably that needs to be removed as well?
>

Yes, but before sending a bunch of patches, I wanted to get your feedback
on this one to avoid wasting time.


>
> git grep 'filter-out.*D_FILE_OFFSET_BITS=' package/**/*mk
> package/elfutils/elfutils.mk:ELFUTILS_CFLAGS = $(filter-out
> -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
> package/elfutils/elfutils.mk:ELFUTILS_CPPFLAGS = $(filter-out
> -D_FILE_OFFSET_BITS=64,$(TARGET_CPPFLAGS))
> package/libselinux/libselinux.mk:       CFLAGS="$(filter-out
> -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))" \
> package/libselinux/libselinux.mk:       CPPFLAGS="$(filter-out
> -D_FILE_OFFSET_BITS=64,$(TARGET_CPPFLAGS))"
> package/ltp-testsuite/ltp-testsuite.mk:LTP_TESTSUITE_CFLAGS =
> $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
> package/ltp-testsuite/ltp-testsuite.mk:LTP_TESTSUITE_CPPFLAGS =
> $(filter-out -D_FILE_OFFSET_BITS=64,$(TARGET_CPPFLAGS))
> package/musl/musl.mk:           CFLAGS="$(filter-out -D_LARGEFILE_SOURCE
> -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64,$(TARGET_CFLAGS))
> $(MUSL_EXTRA_CFLAGS)" \
> package/musl/musl.mk:           CPPFLAGS="$(filter-out
> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> -D_FILE_OFFSET_BITS=64,$(TARGET_CPPFLAGS))" \
>
> --
> Bye, Peter Korsgaard
>

Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20231201/f3c8e56c/attachment-0001.html>