[Buildroot] [PATCH 0/3 v2] support/download: enhance svn backend

[yann.morin at orange.com]

Thomas, All,

On 2023-08-06 16:40 +0200, Thomas Petazzoni spake thusly:
> On Tue, 1 Aug 2023 15:11:14 +0200
> yann.morin at orange.com wrote:
> > Yann E. MORIN (3):
> >       support/download: fix shellcheck errors in svn backend
> >       support/download: use svn credentials to retrieve revision date
> >       support/download: add support to exclude svn externals
> I have applied the series to next. As reported on IRC, the From: field
> is not correct, as it is just From: yann.morin at orange.com, while it
> should be From: Yann E. MORIN <yann.morin at orange.com> to match the
> Signed-off-by value. I fixed that up when applying.

Yeah, that's the mail server here that mangles the outgoing From:
fields... I'll try to coax git into always adding a From pseudo header
as a workaround... Sorry for the mess...

> Another aspect I'd like to challenge though is your decision in PATCH
> 3/3 to preserve the current behavior of downloading externals as the
> default. We have only one package in the tree that uses SVN as far as I
> can see, so it would be easy to verify if this one uses external or
> not, and do the right thing.

I was pondering changing the default, indeed, but that would mean
existing hashes would no longer match. So that would warrant a bump
to BR_FMT_VERSION_svn.

If that's OK, I can work on that.

> Yes, I know this change of the default behavior could break external
> packages,

If we bump BR_FMT_VERSION_svn, they'll more easily notice, and be able
to take action.

> I believe the
> chances of having people having external packages *and* packages that
> use external SVN repositories are fairly slim, so I would think that
> defaulting to *not* downloading the SVN externals would be an
> acceptable change.

I'm not sure about the pervasiveness of svn-externals, but the only
publicly svn-hosted package we needed to introduce in Buildroot does use
externals! ;-)

> We can always mention it in the migration guidelines
> at
> https://buildroot.org/downloads/manual/manual.html#migrating-from-ol-versions
> if we want to be extra nice.

Sure, I'll post a follow-up patch in a moment..

Regards,
Yann E. MORIN.

-- 
                                        ____________
.-----------------.--------------------:       _    :------------------.
|  Yann E. MORIN  | Real-Time Embedded |    __/ )   | /"\ ASCII RIBBON |
|                 | Software  Designer |  _/ - /'   | \ / CAMPAIGN     |
| +33 638.411.245 '--------------------: (_    `--, |  X  AGAINST      |
| yann.morin (at) orange.com           |_="    ,--' | / \ HTML MAIL    |
'--------------------------------------:______/_____:------------------'

____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.