[Buildroot] [PATCH v2 3/5] ackage/rtl8723ds-bt: new package

[Thomas Petazzoni]

On Fri, 14 Oct 2022 08:58:58 +0200
Angelo Compagnucci <angelo at amarulasolutions.com> wrote:

> @@ -78,7 +78,8 @@ LINUX_DEPENDENCIES += \
>  	$(if $(BR2_PACKAGE_INTEL_MICROCODE),intel-microcode) \
>  	$(if $(BR2_PACKAGE_LINUX_FIRMWARE),linux-firmware) \
>  	$(if $(BR2_PACKAGE_FIRMWARE_IMX),firmware-imx) \
> -	$(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb)
> +	$(if $(BR2_PACKAGE_WIRELESS_REGDB),wireless-regdb) \
> +	$(if $(BR2_PACKAGE_RTL8723DS_BT),rtl8723ds-bt)
>  
>  # Starting with 4.16, the generated kconfig paser code is no longer
>  # shipped with the kernel sources, so we need flex and bison, but
> diff --git a/package/Config.in b/package/Config.in
> index e3a34d6e97..4f6e508106 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -578,6 +578,7 @@ endmenu
>  	source "package/rtl8189fs/Config.in"
>  	source "package/rtl8723bu/Config.in"
>  	source "package/rtl8723ds/Config.in"
> +	source "package/rtl8723ds-bt/Config.in"
>  	source "package/rtl8812au-aircrack-ng/Config.in"
>  	source "package/rtl8821au/Config.in"
>  	source "package/sane-backends/Config.in"
> diff --git a/package/rtl8723ds-bt/Config.in b/package/rtl8723ds-bt/Config.in
> new file mode 100644
> index 0000000000..ab4ba0bf11
> --- /dev/null
> +++ b/package/rtl8723ds-bt/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_RTL8723DS_BT
> +	bool "rtl8723ds-bt"
> +	help
> +	  rtl8723ds UART attached Bluetooth driver

So here you're saying this package is for a driver.

> +define RTL8723DS_BT_LINUX_CONFIG_FIXUPS
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_SERIAL_DEV_BUS)
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_SERIAL_DEV_CTRL_TTYPORT)
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_BT)
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_BT_HCIUART)
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_BT_HCIUART_3WIRE)
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_BT_HCIUART_RTL)
> +	$(call KCONFIG_APPEND_OPT,CONFIG_EXTRA_FIRMWARE,rtl_bt/rtl8723ds_fw.bin rtl_bt/rtl8723ds_config.bin)
> +endef
> +
> +define RTL8723DS_BT_INSTALL_STAGING_CMDS
> +	mkdir -p $(STAGING_DIR)/lib/firmware/rtl_bt/
> +	cp $(@D)/8723D/rtl8723d_fw $(STAGING_DIR)/lib/firmware/rtl_bt/rtl8723ds_fw.bin
> +	cp $(@D)/8723D/rtl8723d_config $(STAGING_DIR)/lib/firmware/rtl_bt/rtl8723ds_config.bin

But here you are only installing the firmware file, and you're not
building the kernel module that is provided in this Git repository.

Is it because the driver is in the upstream kernel, and the only part
that it lacks is the firmware?

This is not really clear in your commit log nor in the Config.in help
text.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com