[Buildroot] [PATCH v4] package/gnuradio: bump version to 3.10.4.0
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Thu Oct 6 19:50:57 UTC 2022
Hello,
On Thu, 6 Oct 2022 10:27:57 +0200
Gwenhael Goavec-Merou <gwenj at trabucayre.com> wrote:
> - Since gnuradio 3.10 swig was replaced by pybind. Now python libraries,
> bindings and python wrappers are produces using pybind: this why python-pybind
> is a buildtime dependency. This one is a stagging only package (nothing
> installed into target directory -> no select BR2_PACKAGE_PYTHON_PYBIND
> added to Config.in but GNURADIO_DEPENDENCIES is updated with python-pybind).
I am sorry, but this still doesn't make any sense, and will in fact
cause build failures. A package cannot have a target package in its
<pkg>_DEPENDENCIES variable without selecting it.
If python-pybind is needed at build time on the host, then
GNURADIO_DEPENDENCIES must contain host-python-pybind, and nothing
needs to be done in Config.in.
If python-pybind is needed on the target, then two options:
(1) It's needed only at runtime => it should be selected in Config.in.
(2) It's needed at build-time => it should be selected in Config.in
*and* and added as a dependency in GNURADIO_DEPENDENCIES. However, I'd
like to see a serious justification, because it is really uncommon to
have target Python packages be build-time dependencies.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
More information about the buildroot
mailing list