[Buildroot] [PATCH 1/4] package/nodejs: fixup qemu dependencies

Peter Korsgaard peter at korsgaard.com
Tue Oct 11 18:53:46 UTC 2022


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:

 > Commit 1facb09b94bf806b301868539185c0ff9ddffee2 ("package/nodejs:
 > build host-nodejs only if we're installing modules with NPM") forgot
 > to account for the dependency on Qemu. Now that nodejs no longer
 > depends on host-nodejs, but needs host-qemu, we need to make sure that
 > nodejs selects the relevant BR2_PACKAGE_HOST_QEMU options.

 > So this patch:

 >  - Drops the dependency of BR2_PACKAGE_NODEJS_ARCH_SUPPORTS on
 >    BR2_PACKAGE_QEMU_ARCH_SUPPORTS_TARGET, which was incorrect: we
 >    don't care about running Qemu on the target. We care about
 >    host-qemu supporting the emulation of the target architecture,
 >    which is what BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS is for.

 >  - Adds the dependency to the relevant BR2_PACKAGE_HOST_QEMU options
 >    to BR2_PACKAGE_NODEJS, so that host-qemu is built with the
 >    appropriate features needed to build the target nodejs.

 >  - Removes the qemu related dependencies from host-nodejs, which does
 >    not need Qemu at all.

 > Without this change the build of nodejs without npm enabled is broken
 > as the host-qemu that gets built does not have all the features that
 > are needed. There are no autobuild failures at this point, however.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>

Committed to 2022.08.x, thanks.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list