[Buildroot] [PATCH 1/1] package/popt: bump to version 1.19

[Fabrice Fontaine]

Hi,

Le mer. 16 nov. 2022 à 00:48, Florian Fainelli <f.fainelli at gmail.com> a
écrit :

> Hi Fabrice,
>
> On 9/17/22 14:17, Fabrice Fontaine wrote:
> > - Drop patches (already in version) and so autoreconf
> > - Update hash of COPYING (license adjusted to use the original, straight
> >    MIT variant:
> >
> https://github.com/rpm-software-management/popt/commit/dcec86df3cfc96d3dd3a3e9f7f1086b768d2d88f
> )
> >
> >
> https://github.com/rpm-software-management/popt/compare/popt-1.18-release...popt-1.19-release
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
>
> We recently upgraded from buildroot 2022.08 to 2022.11-rc1 which
> contains this change of yours and this causes gptfdisk's sgdisk to not
> be able to open the devices passed as argument, steps to reproduce would
> be as simple as:
>
> # sgdisk -p /dev/sda
> Problem opening  for reading! Error is 2.
> The specified file does not exist!
>
> Markus looked at the strace output and found the following:
>
> strace -f sgdisk -p /dev/sda
> [...]
> brk(NULL)                               = 0x5581f4d000
> brk(0x5581f6e000)                       = 0x5581f6e000
> brk(0x5581f8f000)                       = 0x5581f8f000
> openat(AT_FDCWD, "", O_RDONLY)          = -1 ENOENT (No such file or
> directory)
> write(2, "Problem opening ", 16Problem opening )        = 16
> write(2, " for reading! Error is ", 23 for reading! Error is ) = 23
> write(2, "2", 12)                        = 1
> write(2, ".\n", 2.
> )                      = 2
> write(2, "The specified file does not exis"..., 35The specified file
> does not exist!
> ) = 35
> exit_group(2)                           = ?
> +++ exited with 2 +++
>
> the openat() system call is passed an empty string which is the reason
> for sgdisk to fail opening the specified device. Reverting libpopt back
> to 1.18 but keeping everything else the same resolves the issue.
>
> Is this is a known problem? Thanks!
>

Yes, this is a known issue raised because the value returned by
poptGetArg() doesn't leak anymore:
https://github.com/rpm-software-management/popt/issues/80

I'll send a patch to apply the gptfdisk partial fix mentioned above.


> --
> Florian
>
> Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20221116/7c1e82aa/attachment-0001.html>