[Buildroot] [PATCH 1/1] package/libdcadec: remove package

Yann E. MORIN yann.morin.1998 at free.fr
Sat Nov 5 18:14:24 UTC 2022


Bernd, All,

On 2022-11-05 08:51 +0100, Bernd Kuhls spake thusly:
> Quoting https://github.com/foo86/dcadec
> 
> "This program is deprecated!
> 
>  This decoder has been fully integrated into FFmpeg master branch and
>  further development will continue there. Using FFmpeg for DTS decoding
>  is now recommended."

I've added a little blurb that the package has had no commit for the
past 7+ years, too.

> Fixes:
> http://autobuild.buildroot.net/results/1e63586c91a2670ecac2940f6e9840e6801c32f3/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>

Since we're now in feature-freeze, I was considering whther to apply to
master or next. I opted for master, as nothinf uses libdcadec in
Buildroot, and so removing it should not cause any issue (famous last
words).

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  Config.in.legacy                 |  8 ++++++++
>  DEVELOPERS                       |  1 -
>  package/Config.in                |  1 -
>  package/libdcadec/Config.in      |  7 -------
>  package/libdcadec/libdcadec.hash |  3 ---
>  package/libdcadec/libdcadec.mk   | 33 --------------------------------
>  6 files changed, 8 insertions(+), 45 deletions(-)
>  delete mode 100644 package/libdcadec/Config.in
>  delete mode 100644 package/libdcadec/libdcadec.hash
>  delete mode 100644 package/libdcadec/libdcadec.mk
> 
> diff --git a/Config.in.legacy b/Config.in.legacy
> index 0e63d59a98..7458fa331e 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -146,6 +146,14 @@ endif
>  
>  comment "Legacy options removed in 2022.11"
>  
> +config BR2_PACKAGE_LIBDCADEC
> +	bool "package was deprecated upstream, use ffmpeg instead"
> +	select BR2_LEGACY
> +	help
> +	  This decoder has been fully integrated into FFmpeg master
> +	  branch and further development will continue there. Using
> +	  FFmpeg for DTS decoding is now recommended.
> +
>  config BR2_KERNEL_HEADERS_5_17
>  	bool "kernel headers version 5.17.x are no longer supported"
>  	select BR2_LEGACY
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 4750c06b64..f7c6c71e6f 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -363,7 +363,6 @@ F:	package/libcdio/
>  F:	package/libcec/
>  F:	package/libcodec2/
>  F:	package/libcrossguid/
> -F:	package/libdcadec/
>  F:	package/libdeflate/
>  F:	package/libdrm/
>  F:	package/libdvbcsa/
> diff --git a/package/Config.in b/package/Config.in
> index d14e7473b6..c0ff8c9144 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1787,7 +1787,6 @@ menu "Multimedia"
>  	source "package/libbluray/Config.in"
>  	source "package/libcamera/Config.in"
>  	source "package/libcamera-apps/Config.in"
> -	source "package/libdcadec/Config.in"
>  	source "package/libdvbcsa/Config.in"
>  	source "package/libdvbpsi/Config.in"
>  	source "package/libdvbsi/Config.in"
> diff --git a/package/libdcadec/Config.in b/package/libdcadec/Config.in
> deleted file mode 100644
> index 2687a18187..0000000000
> --- a/package/libdcadec/Config.in
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -config BR2_PACKAGE_LIBDCADEC
> -	bool "libdcadec"
> -	help
> -	  dcadec is a free DTS Coherent Acoustics decoder with support
> -	  for HD extensions.
> -
> -	  https://github.com/foo86/dcadec
> diff --git a/package/libdcadec/libdcadec.hash b/package/libdcadec/libdcadec.hash
> deleted file mode 100644
> index 3c3e80e8a3..0000000000
> --- a/package/libdcadec/libdcadec.hash
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -# Locally calculated
> -sha256  ed9d207fde3e8d576f3af8b0d1235b3371e315175757173689104efcaebf0d44  libdcadec-0.2.0.tar.gz
> -sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  COPYING.LGPLv2.1
> diff --git a/package/libdcadec/libdcadec.mk b/package/libdcadec/libdcadec.mk
> deleted file mode 100644
> index a3579ad632..0000000000
> --- a/package/libdcadec/libdcadec.mk
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -################################################################################
> -#
> -# libdcadec
> -#
> -################################################################################
> -
> -LIBDCADEC_VERSION = 0.2.0
> -LIBDCADEC_SITE = $(call github,foo86,dcadec,v$(LIBDCADEC_VERSION))
> -LIBDCADEC_LICENSE = LGPL-2.1+
> -LIBDCADEC_LICENSE_FILES = COPYING.LGPLv2.1
> -LIBDCADEC_INSTALL_STAGING = YES
> -
> -ifeq ($(BR2_STATIC_LIBS),)
> -LIBDCADEC_SHARED = CONFIG_SHARED=1
> -endif
> -
> -define LIBDCADEC_BUILD_CMDS
> -	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> -		CFLAGS="$(TARGET_CFLAGS) -std=gnu99" \
> -		$(LIBDCADEC_SHARED) -C $(@D)
> -endef
> -
> -define LIBDCADEC_INSTALL_STAGING_CMDS
> -	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
> -		$(LIBDCADEC_SHARED) DESTDIR=$(STAGING_DIR) PREFIX=/usr install
> -endef
> -
> -define LIBDCADEC_INSTALL_TARGET_CMDS
> -	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
> -		$(LIBDCADEC_SHARED) DESTDIR=$(TARGET_DIR) PREFIX=/usr install
> -endef
> -
> -$(eval $(generic-package))
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list