[Buildroot] [PATCH 2/3] package/qemu: select FDT for custom targets too

[Thomas Huth]

Am Fri,  4 Nov 2022 20:57:26 -0300
schrieb unixmania at gmail.com:

> From: Carlos Santos <unixmania at gmail.com>
> 
> Custom targets selects system and Linux user-land emulation, which in
> their turn require FDT. Move the BR2_PACKAGE_QEMU_FDT selection to the
> BR2_PACKAGE_QEMU_HAS_EMULS hidden boolean, to cover all cases.
> 
> Signed-off-by: Carlos Santos <unixmania at gmail.com>
> ---
>  package/qemu/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/qemu/Config.in b/package/qemu/Config.in
> index 8b8a999885..9e0cbd4acf 100644
> --- a/package/qemu/Config.in
> +++ b/package/qemu/Config.in
> @@ -95,7 +95,6 @@ comment "... or you can select emulator families to enable, below:"
>  config BR2_PACKAGE_QEMU_SYSTEM
>  	bool "Enable all systems emulation"
>  	depends on !BR2_STATIC_LIBS # dtc
> -	select BR2_PACKAGE_QEMU_FDT
>  	help
>  	  Say 'y' to build all system emulators/virtualisers that QEMU
>  	  supports.
> @@ -121,6 +120,7 @@ endif # BR2_PACKAGE_QEMU_CUSTOM_TARGETS == ""
>  config BR2_PACKAGE_QEMU_HAS_EMULS
>  	def_bool y
>  	depends on BR2_PACKAGE_QEMU_SYSTEM || BR2_PACKAGE_QEMU_LINUX_USER || BR2_PACKAGE_QEMU_CUSTOM_TARGETS != ""
> +	select BR2_PACKAGE_QEMU_FDT

Technically, I think you don't need FDT if you are only compiling the
linux-user targets ... so maybe it would be better to add this to the
BR2_PACKAGE_QEMU_CUSTOM_TARGETS switch instead?

 Thomas