[Buildroot] [PATCH v3 1/1] package/iwd: add dbus compile time dependency

Lang Daniel d.lang at abatec.at
Mon Nov 14 07:18:28 UTC 2022


Hi James,

> In 5b3b2d80f4cf586d360ff696c3dacbd4cb48fdc4 we dropped dbus as a build
> dependency, however we still need it when building with systemd so
> that the service directory is available via pkg-config.

Sorry for getting this whole mess started.
I only did a compile test without systemd before submitting the patch.

I guess the comment in package/iwd/Config.in:8 should be removed then,
since that's what got me started.

> In addition we can drop --with-dbus-datadir by unconditionally
> requiring dbus as the datadir will then be fetched from pkg-config.
>
> Fixes:
> checking D-Bus bus services directory... configure: error: D-Bus bus services directory is required
>
> Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
> ---
> Changes v2 -> v3:
>   - always depend on dbus
> Changes v1 -> v2:
>   - depend on dbus when depending on systemd
> ---
>  package/iwd/iwd.mk | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/package/iwd/iwd.mk b/package/iwd/iwd.mk
> index 002988cf33..5ffbde334e 100644
> --- a/package/iwd/iwd.mk
> +++ b/package/iwd/iwd.mk
> @@ -16,9 +16,8 @@ IWD_SELINUX_MODULES = networkmanager
>  IWD_CONF_OPTS = \
>          --disable-manual-pages \
>          --enable-external-ell \
> -       --enable-dbus-policy \
> -       --with-dbus-datadir=/usr/share
> -IWD_DEPENDENCIES = ell
> +       --enable-dbus-policy
> +IWD_DEPENDENCIES = dbus ell
>  
>  ifeq ($(BR2_PACKAGE_READLINE),y)
>  # iwd client depends on readline (GPL-3.0+)
> -- 
> 2.34.1


More information about the buildroot mailing list