[Buildroot] [PATCH] boot/arm-trusted-firmware: don't enable SSP by default
Peter Korsgaard
peter at korsgaard.com
Wed Nov 2 22:45:03 UTC 2022
>>>>> "Baruch" == Baruch Siach via buildroot <buildroot at buildroot.org> writes:
> SSP support requires support in ATF platform code. Not all platforms
> implement plat_get_stack_protector_canary() hook. The result is build
> failure:
> (.text.asm.update_stack_protector_canary+0x4): undefined reference to `plat_get_stack_protector_canary'
> Commit cf176128ec4 ("boot/arm-trusted-firmware: add SSP option")
> originally introduces this issue. But then commit ccac9a5bbbd
> ("boot/arm-trusted-firmware: don't force ENABLE_STACK_PROTECTOR") hid
> the problem by effectively disabling SSP for all platforms. So only
> after commit 09acc7cbc91f5 ("boot/arm-trusted-firmware: fix SSP
> support") the issue showed up.
> Make SSP an opt-in for platform that actually provide the
> plat_get_stack_protector_canary() hook.
> Cc: Sergey Matyukevich <geomatsi at gmail.com>
> Cc: Dick Olsson <hi at senzilla.io>
> Tested-by: Heiko Thiery <heiko.thiery at gmail.com>
> Signed-off-by: Baruch Siach <baruch at tkos.co.il>
Committed to 2022.08.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list