[Buildroot] [PATCH 1/1] package/midori: add missing !BR2_PACKAGE_GNUPG dependency

[James Hilliard]

On Tue, May 24, 2022 at 1:01 PM Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>
> James, Arnout, All,
>
> On 2022-05-18 21:17 +0200, Arnout Vandecappelle spake thusly:
> > On 15/05/2022 00:28, James Hilliard wrote:
> > >The !BR2_PACKAGE_GNUPG needs to be propagated from BR2_PACKAGE_GCR.
> > >
> > >Fixes:
> > >WARNING: unmet direct dependencies detected for BR2_PACKAGE_GCR
> > >   Depends on [n]: BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_MMU [=y] && !BR2_STATIC_LIBS [=n] && !BR2_PACKAGE_GNUPG [=y]
> > >   Selected by [y]:
> > >   - BR2_PACKAGE_MIDORI [=y] && BR2_PACKAGE_MIDORI_ARCH_SUPPORTS [=y] && !BR2_STATIC_LIBS [=n] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_HOST_GCC_AT_LEAST_8 [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_7 [=y] && BR2_TOOLCHAIN_USES_GLIBC [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_TOOLCHAIN_HAS_SYNC_4 [=y] && BR2_USE_WCHAR [=y] && BR2_PACKAGE_LIBGTK3 [=y] && (BR2_PACKAGE_LIBGTK3_X11 [=y] || BR2_PACKAGE_LIBGTK3_WAYLAND [=n])
> > >
> > >Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
> > >---
> > >  package/midori/Config.in | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > >diff --git a/package/midori/Config.in b/package/midori/Config.in
> > >index 715295e5a6..54e19d4d34 100644
> > >--- a/package/midori/Config.in
> > >+++ b/package/midori/Config.in
> > >@@ -25,6 +25,7 @@ config BR2_PACKAGE_MIDORI
> > >     bool "midori"
> > >     depends on BR2_PACKAGE_MIDORI_ARCH_SUPPORTS
> > >     depends on !BR2_STATIC_LIBS # webkitgtk
> > >+    depends on !BR2_PACKAGE_GNUPG # gcr
> >  You forget to add a comment for this.
> >  Applied to master with that fixed, thanks.
>
> Unfortunately, as Romain noticed, this is causing a circular (aka
> recursive) kconfig dependency:
>
>     $ make distclean; make defconfig
>     [...]
>     package/gstreamer1/gstreamer1/Config.in:5:error: recursive dependency detected!
>     package/gstreamer1/gstreamer1/Config.in:5:      symbol BR2_PACKAGE_GSTREAMER1 is selected by BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
>     package/webkitgtk/Config.in:90: symbol BR2_PACKAGE_WEBKITGTK_MULTIMEDIA depends on BR2_PACKAGE_WEBKITGTK
>     package/webkitgtk/Config.in:24: symbol BR2_PACKAGE_WEBKITGTK is selected by BR2_PACKAGE_MIDORI
>     package/midori/Config.in:28:    symbol BR2_PACKAGE_MIDORI depends on BR2_PACKAGE_GNUPG
>     package/gnupg/Config.in:1:      symbol BR2_PACKAGE_GNUPG is selected by BR2_PACKAGE_PYTHON_GNUPG
>     package/python-gnupg/Config.in:1:       symbol BR2_PACKAGE_PYTHON_GNUPG depends on BR2_PACKAGE_PYTHON3
>     package/python3/Config.in:5:    symbol BR2_PACKAGE_PYTHON3 is selected by BR2_PACKAGE_JACK2_DBUS
>     package/jack2/Config.in:35:     symbol BR2_PACKAGE_JACK2_DBUS depends on BR2_PACKAGE_JACK2
>     package/jack2/Config.in:1:      symbol BR2_PACKAGE_JACK2 is selected by BR2_PACKAGE_FLUIDSYNTH_JACK2
>     package/fluidsynth/Config.in:38:        symbol BR2_PACKAGE_FLUIDSYNTH_JACK2 depends on BR2_PACKAGE_FLUIDSYNTH
>     package/fluidsynth/Config.in:1: symbol BR2_PACKAGE_FLUIDSYNTH is selected by BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_FLUIDSYNTH
>     package/gstreamer1/gst1-plugins-bad/Config.in:438:      symbol BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_FLUIDSYNTH depends on BR2_PACKAGE_GSTREAMER1
>
> James, can you look at it, please?

Yeah, already sent a patch that should fix this:
https://patchwork.ozlabs.org/project/buildroot/patch/20220519045549.2320246-1-james.hilliard1@gmail.com/

>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'