[Buildroot] [PATCH] boot/optee-os: add support for custom tarball URL

[Etienne Carriere]

On Tue, 21 Jun 2022 at 15:45, Köry Maincent <kory.maincent at bootlin.com> wrote:
>
> Hello Etienne,
>
> Thanks for the review!
>
> > > diff --git a/boot/optee-os/optee-os.mk b/boot/optee-os/optee-os.mk
> > > index 88f14b48e4..cc90cff2cb 100644
> > > --- a/boot/optee-os/optee-os.mk
> > > +++ b/boot/optee-os/optee-os.mk
> > > @@ -13,14 +13,22 @@ endif
> > >  OPTEE_OS_INSTALL_STAGING = YES
> > >  OPTEE_OS_INSTALL_IMAGES = YES
> > >
> > > -ifeq ($(BR2_TARGET_OPTEE_OS_CUSTOM_GIT),y)
> > > +ifeq ($(OPTEE_OS_VERSION),custom)
> >
> > It looks strange to me that "custom" is a reserved version identifier
> > when using a custom tarball.
> > I'd rather use:
> >    ifeq ($(BR2_TARGET_OPTEE_OS_CUSTOM_TARBALL),y)
>
> I have copied the same mechanism as U-boot and TF-A.
> I don't know what's the better way, if you prefer this I can change it.
>

I really prefer my proposal.
Is "custom" a reserved version identifier in Buildroot configuration
switches? I can't tell but i think it'd be a bit fragile.


> > > +ifeq ($(call qstrip,$(BR2_TARGET_OPTEE_OS_CUSTOM_TARBALL_LOCATION))),)
> > > +$(error No tarball location specified. Please check
> > > BR2_TARGET_OPTEE_OS_CUSTOM_TARBALL_LOCATION))
> >
> > There is a extra ending parentheses to be removed in each of the 2 above
> > lines.
>
> True, and TF-A has the same issue! :)

Maybe you can fix it by the way!

etienne

>
> Köry