[Buildroot] [PATCH v3, 1/1] package/zstd: fix build without threads

[Yann E. MORIN]

Fabrice, All,

On 2022-06-12 20:13 +0200, Fabrice Fontaine spake thusly:
> Le dim. 12 juin 2022 à 19:13, Yann E. MORIN <yann.morin.1998 at free.fr> a écrit :
> > On 2022-06-12 18:02 +0200, Fabrice Fontaine spake thusly:
> > > Move libzstd.pc in ZSTD_BUILD_LIBS so it will be suffixed by -nomt
> > > without threads. As a result, libzstd.pc will not contain -pthread in
> > > Libs.Private which will avoid the following static build failure with
> > > zchunk) raised since commit 0f0e913f10caf21f23c2e46f210519a7a3bc0b32:
> > >
> > > /home/buildroot/autobuild/instance-2/output-1/host/bin/aarch64_be-buildroot-linux-uclibc-gcc  -o src/unzck src/unzck.p/unzck.c.o src/unzck.p/util_common.c.o -Wl,--as-needed -Wl,--no-undefined -static -Wl,--start-group src/lib/libzck.a -largp /home/buildroot/autobuild/instance-2/output-1/host/aarch64_be-buildroot-linux-uclibc/sysroot/usr/lib/libzstd.a -pthread /home/buildroot/autobuild/instance-2/output-1/host/aarch64_be-buildroot-linux-uclibc/sysroot/usr/lib/libssl.a /home/buildroot/autobuild/instance-2/output-1/host/aarch64_be-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a -Wl,--end-group
> > > /home/buildroot/autobuild/instance-2/output-1/host/lib/gcc/aarch64_be-buildroot-linux-uclibc/10.3.0/../../../../aarch64_be-buildroot-linux-uclibc/bin/ld: cannot find -lpthread
> > >
> > > Fixes:
> > >  - http://autobuild.buildroot.org/results/481d1979920daaecac48dec763151e124651740f
> > So, I was very curious how the weird buildsystem for zstd would cope,
> > and I am afraid it does not cope well:
> >
> >     $ wget -O .config 'http://autobuild.buildroot.org/results/481d1979920daaecac48dec763151e124651740f/config'
> >     $ make menuconfig
> >         -> switch to a bootlin toolchain (uClibc only, similar to the
> >            failing build)
> Why are you switching to a different toolchain instead of using the
> same defconfig?

To speed up the build...

> Indeed, to my understanding of
> toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options,
> all uclibc bootlin toolchains have thread support ...

Good point. Lemme retry that, then.

> If needed, I can send a v4 that applies cleanly on master.

That will no be necessary, I can fix it up when applying.

However, do you have local changes on zstd, that you will be sending
next?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'