[Buildroot] [PATCH 1/4] package/wpa_supplicant: fixing "Invalid configuration line"

[Angelo Compagnucci]

On Mon, Jun 6, 2022 at 2:42 PM Arnout Vandecappelle <arnout at mind.be> wrote:

>
>
> On 01/06/2022 23:55, Angelo Compagnucci wrote:
> >
> >
> > On Wed, Jun 1, 2022 at 9:21 PM Thomas Petazzoni <
> thomas.petazzoni at bootlin.com
> > <mailto:thomas.petazzoni at bootlin.com>> wrote:
> >
> >     On Fri, 27 May 2022 12:33:32 +0200
> >     Angelo Compagnucci <angelo at amarulasolutions.com
> >     <mailto:angelo at amarulasolutions.com>> wrote:
> >
> >      > Default configuration file is wrong for the default compiling
> options.
> >      >
> >      > Fixes:
> >      >
> >      > Successfully initialized wpa_supplicant
> >      > Line 1: unknown global field
> 'ctrl_interface=/var/run/wpa_supplicant'.
> >      > Line 1: Invalid configuration line
> >      > 'ctrl_interface=/var/run/wpa_supplicant'.
> >      > Failed to read or parse configuration '/etc/wpa_supplicant.conf'.
> >      >
> >      > Signed-off-by: Angelo Compagnucci <angelo at amarulasolutions.com
> >     <mailto:angelo at amarulasolutions.com>>
> >
> >     Indeed, this option only makes sense when
> >     BR2_PACKAGE_WPA_SUPPLICANT_CTRL_IFACE=y I suppose. However, in this
> >     case, it makes sense a lot of sense to have this option in the config
> >     file.
> >
> >     Should we have some kind of logic to add this line when
> >     BR2_PACKAGE_WPA_SUPPLICANT_CTRL_IFACE=y ?
> >
> >     Maybe something like this:
> >
> >     # ctrl_interface=/var/run/wpa_supplicant #
> BR2_PACKAGE_WPA_SUPPLICANT_CTRL_IFACE
> >
> >     and a bit of $(SED) magic in the .mk file ?
> >
> >
> > No need to have this logic in my opinion:
> > * the option has a sensible default when enabled
>
>   Does it? AFAIK, if ctrl_interface is not specified in the config file or
> on
> the command line with -C, then no control socket will be created.
>
> > * If a user really needs to change the default, he can add that line
> manually in
> > an overlay file.
>
>   Yeah, but we prefer that if a user selects
> BR2_PACKAGE_WPA_SUPPLICANT_CTRL_IFACE, that the control socket actually
> appears
> in the expected place (/var/run/wpa_supplicant).
>

The problem here is that wpa_supplicant.conf file will always be provided
in a user overlay, because to connect to a wifi a proper `network=`
configuration settings must be provided.
Would we really like to mess with a user overlay provided configuration
file? I think that a user must ensure the configuration file is in good
shape for the service to work.


>
>   Regards,
>   Arnout
>
> >
> >
> >     Best regards,
> >
> >     Thomas
> >     --
> >     Thomas Petazzoni, co-owner and CEO, Bootlin
> >     Embedded Linux and Kernel engineering and training
> >     https://bootlin.com <https://bootlin.com>
> >
> >
> >
> > --
> >
> > Angelo Compagnucci
> >
> > Software Engineer
> >
> > angelo at amarulasolutions.com <mailto:angelo at amarulasolutions.com>
> > __________________________________
> > Amarula Solutions SRL
> >
> > Via le Canevare 30, 31100 Treviso, Veneto, IT
> >
> > T. +39 (0)42 243 5310
> > info at amarulasolutions.com <mailto:info at amarulasolutions.com>
> >
> > www.amarulasolutions.com <http://www.amarulasolutions.com/>
> >
> > [`as] https://www.amarulasolutions.com <https://www.amarulasolutions.com
> >|
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>


-- 

Angelo Compagnucci

Software Engineer

angelo at amarulasolutions.com
__________________________________
Amarula Solutions SRL

Via le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 (0)42 243 5310
info at amarulasolutions.com

www.amarulasolutions.com
[`as] https://www.amarulasolutions.com|
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20220607/ded0885d/attachment-0001.html>