[Buildroot] [RFC PATCH 0/1] Fix binutils/libiberty target install directory

[Yann E. MORIN]

Jonathan, All,

On 2022-01-26 16:30 +0100, Jonathan Borne via buildroot spake thusly:
> ----- On Jan 24, 2022, at 10:53 PM, Thomas Petazzoni thomas.petazzoni at bootlin.com wrote:
> > On Mon, 24 Jan 2022 22:21:49 +0100
> > "Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:
> >> As such, when BR2_PACKAGE_BINUTILS_TARGET=n, then the full binutils are
> >> instaleld in target, so the libs will be installed in target.
> I think you made a typo here... 
> The full binutils install to target is made when BR2_PACKAGE_BINUTILS_TARGET=y.

Hehe... ;-)

> >> So whatever gets in staging is present in target, but target can be a
> >> superset of what is in staging, so whatever links to a binutils lib from
> >> staging will find it in target.
> 
> Agreed! So if I understand correctly, as was suggested by Romain and Thomas,
> we could indeed get rid of
> 
> $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install
> 
> in BINUTILS_INSTALL_TARGET_CMDS.

Yes, but to avoid any confusion, please also add a comment above the
staging installation commands that states that libiberty is static only,
as Baruch pointed out earlier.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'