[Buildroot] [PATCH 4/5 v2] package/pkg-golang: allow packages to define download environment

[Christian Stewart]

Hi,

On Wed, Feb 9, 2022 at 8:09 AM <yann.morin at orange.com> wrote:
>
> From: "Yann E. MORIN" <yann.morin at orange.com>
>
> Currently, the golang infrastructure forcibly sets the package _DL_ENV
> variable, instead of appending to it, which prevents packages from
> providing their own download environment variables.
>
> We fix that by using an append-assignment.
>
> Note: when introduced, that variable was explicitly not documented, and
> is supposed to only be used by packages infrastructures. However, that
> variable exists, and it can be (ab)used by br2-external packages (most
> probably to ill effects, but heh!). We anyway leave it undocumented,
> like _ROOTFS_PRE_CMD_HOOKS.
>
> Signed-off-by: Yann E. MORIN <yann.morin at orange.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Christian Stewart <christian at paral.in>
> Cc: Anisse Astier <anisse at astier.eu>
> ---
>  package/pkg-golang.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-golang.mk b/package/pkg-golang.mk
> index 35bcb1673b..69eae02830 100644

Reviewed-by: Christian Stewart <christian at paral.in>

Best,
Christian