[Buildroot] [PATCH v2] configs/orangepi_zero_defconfig: switch to extlinux

[Giulio Benetti]

Hi Sergey,

> Il giorno 6 feb 2022, alle ore 00:17, Sergey Kuzminov <kuzminov.sergey81 at gmail.com> ha scritto:
> 
> 06.02.2022 02:13, Giulio Benetti пишет:
>> Hi Sergey,
>>> On 06/02/22 00:04, Sergey Kuzminov wrote:
>>> Hi Giulio,
>>> 
>>> 06.02.2022 01:18, Giulio Benetti:
>>>> Hi Sergey,
>>>> 
>>>> below I give you a better example of commit log,
>>>> and the dealing with V1->V2 series.
>>>> 
>>>>> Il giorno 5 feb 2022, alle ore 22:56, Sergey Kuzminov <kuzminov.sergey81 at gmail.com> ha scritto:
>>>>> 
>>>>> Changes:
>>>>> v1:
>>>> 
>>>> Please Remove this line ^^^
>>>> 
>>>>> - Exclude FAT partition, it is no longer needed for U-Boot.
>>>>> - Switch the rootfs partition from MBR to GPT for partition-uuid to work.
>>>>> - Switch to extlinux, this is convenient for debugging.
>>>>> - Create common scenarios for multiple boards to create an SD image: board/orangepi/common.
>>>>> 
>>>>> v2:
>>>> Remove this ^^^ line
>>>>> - Fix typo in first line of changes (s/he/it).
>>>> This too ^^^
>>>>> - Add BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW=y.
>>>> Here we need an explanation of the reason why, what this implies.
>>>>> - Exclude one boot option from extlinux.conf.
>>>> This ^^^ too
>>>>> 
>>>>> Signed-off-by: Sergey Kuzminov <kuzminov.sergey81 at gmail.com>
>>>> —-
>>>> V1->V2:
>>>> * improved commit log
>>>> * removed commented line in extlinux.conf
>>>> * removed one boot option from extlinux.conf
>>>>> ---
>>>> 
>>>> So as you can see, commit log doesn’t mention the patch version, while after the 3 dashes you
>>>> can write in general whatever you want because it won’t be part of commit log and it’s usually used
>>>> to report V1->V2 version etc.
>>> 
>>> Changes:
>>> * Exclude FAT partition, it is no longer needed for U-Boot.
>>> * Switch the rootfs partition from MBR to GPT for partition-uuid to work.
>>> * Switch to extlinux, this is convenient for debugging.
>>> * Create common scenarios for multiple boards to create an SD image:
>>> board/orangepi/common.
>>> * Add BR2_TARGET_GENERIC_REMOUNT_ROOTFS_RW=y, remount root filesystem
>>> read-write during boot.
>>> 
>>> ---
>>> V1->V2:
>>> * improved commit log
>>> * removed commented line in extlinux.conf
>>> * removed one boot option from extlinux.conf
>>> 
>>> V2->V3:
>>> * improved commit log
>>> 
>>> That's right?
>> Yes, this works for me now
>>> 
>>>>> +++ b/board/orangepi/common/genimage.cfg
>>>>> @@ -0,0 +1,23 @@
>>>>> +image sdcard.img {
>>>>> +    partition u-boot {
>>>>> +        in-partition-table = false
>>>>> +        image = "u-boot-sunxi-with-spl.bin"
>>>>> +        offset = 8K
>>>>> +        size = 1000K # 1MB - 8KB(offset) - 16KB(GPT)
>>>>> +    }
>>>>> +
>>>>> +    hdimage {
>>>>> +        partition-table-type = gpt
>>>>> +        gpt-location = 1008K # 1MB - 16KB(GPT)
>>>>> +        gpt-no-backup = true
>>>>> +        # After writing the image to the SD card,
>>>>> +        # backup GPT data structures at the end of the disk:
>>>>> +        # gdisk /dev/mmcblk0 then press the buttons: x, e, w, y
>>>> 
>>>> Why don’t you make this part ^^^ automatic with a script or you simply use genimage itself?
>>>> 
>>>> What it’s expected as board defconfig is something that you burn a sdcard with the sdcard.img file and that’s it. So here you need to make it automatic.
>>>> 
>>>> So we wait for V3 with the commit log form you read above and requested changes.
>>> 
>>> The problem is that it is not possible to create an sdcard.img image
>>> with the correct GPT structure. The second copy of the GPT must be at
>>> the end of the disk, and the size of sdcard.img will not match the SD
>>> card. Will work and so, with one copy of GPT. But the disk utilities may
>>> issue a warning about the absence of a second copy of the GPT. You can
>>> correct the situation only after writing sdcard.img to the SD card, or
>>> during the first loading of the board in a separate script. This is out
>>> of scope for this patch.
>> Ok, so please remove those 3 commented lines since I think the board actually works without those additional commands, correct?
> 
> Yes.

Perfect, so you can send the V3 patch.
Please remember to keep my Reviewed-by and Tested-by after your SoB that I’ve given you on V1 patch.

You can follow patchwork here:
https://patchwork.ozlabs.org/project/buildroot/list/

You should also subscribe to patchwork and mark your V1 and V2 patches as superseded.

Thank you
Giulio

> 
>> Otherwise, it this doesn't work on target without gdisk commands, you need to add a post-image.sh script to launch those commands.
>> Thank you!
>> Best regards
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20220206/4bad7935/attachment-0001.html>