[Buildroot] [PATCH 1/1] package/tiff: add libdeflate optional dependency

[Fabrice Fontaine]

Hello,


Le mar. 27 déc. 2022 à 22:35, Thomas Petazzoni <thomas.petazzoni at bootlin.com>
a écrit :

> On Thu, 22 Dec 2022 17:51:17 +0100
> Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:
>
> > libdeflate is an optional dependency which is enabled by default since
> > version 4.2.0 and
> >
> https://gitlab.com/libtiff/libtiff/-/commit/3a2de853a932bd0ea79d1677d319841edb736c38
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> > ---
> >  package/tiff/Config.in | 6 ++++++
> >  package/tiff/tiff.mk   | 7 +++++++
> >  2 files changed, 13 insertions(+)
> >
> > diff --git a/package/tiff/Config.in b/package/tiff/Config.in
> > index f842c2ead8..58e2052ea5 100644
> > --- a/package/tiff/Config.in
> > +++ b/package/tiff/Config.in
> > @@ -11,6 +11,12 @@ config BR2_PACKAGE_TIFF_CCITT
> >       bool "CCITT Group 3 & 4 support"
> >       default y
> >
> > +config BR2_PACKAGE_TIFF_LIBDEFLATE
> > +     bool "Libdeflate usage (still requires Zlib)"
> > +     default y
>
> Is there any reason to have this "default y"? We normally try to
> disable optional features by default, especially if they bring extra
> dependencies.
>
> I see it's a policy that has not been really applied to the tiff
> package, but I'm wondering if there's a particular reason to not apply
> our normal policy to this new option?
>

I decided to enable it by default for backward compatibility and because
(for an unknown reason) most tiff options are enabled by default but I can
send a v2 if needed.


>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20221227/3cf5e511/attachment-0001.html>