[Buildroot] [PATCH 2/2] package/rtl8192eu: fix build failure on Big Endian architectures

[Giulio Benetti]

Hello Thomas, Arnout, All,

On 11/12/22 21:29, Thomas Petazzoni via buildroot wrote:
> On Tue, 29 Nov 2022 23:25:29 +0100
> Giulio Benetti <giulio.benetti at benettiengineering.com> wrote:
> 
>>> Clearly, all of this is rubbish in Buildroot context. So what we should do is to set
>>>
>>> RTL8192EU_MODULE_MAKE_OPTS = ... CONFIG_PLATFORM_I386_PC=n
>>>
>>> At that point, we can set all the appropriate config options we like, which would be the -DCONFIG_IOCTL_CFG80211 -DRTW_USE_CFG80211_STA_EVENT in USER_EXTRA_CFLAGS.
>>
>> Yes, this is another approach, but there is only a patch with my proposed solution applied [1]
>> so maybe for consistency we could keep it the same, what about it?
> 
> Well, Arnout has a point that having CONFIG_PLATFORM_I386_PC=y is not
> really good. 


Yes, I've rechecked the Makefile and Arnout had a very good idea that
gives us the total control and I've sent a V2 patch for this:
https://patchwork.ozlabs.org/project/buildroot/patch/20221213203236.171656-1-giulio.benetti@benettiengineering.com/

> So perhaps 354f9387f33b5fab023cb98e52d84d58624f0ecf also
> needs to be changed like Arnout suggested?

Yes, I've sent one for this too:
https://patchwork.ozlabs.org/project/buildroot/patch/20221213211313.735422-1-giulio.benetti@benettiengineering.com/

If new bugs like this arise I will use that approach now on.

Thank you both!
Best regards
-- 
Giulio Benetti
Benetti Engineering sas