[Buildroot] [PATCH 2/2] package/mender-artifact: remove unnecessary GO_ENV
Yann E. MORIN
yann.morin.1998 at free.fr
Sun Dec 4 17:36:12 UTC 2022
Patrick, All,
On 2022-12-04 15:06 +0100, Patrick Gerber via buildroot spake thusly:
> All go packages are built with:
> GOFLAGS="-mod=vendor"
> (see HOST_GO_COMMON_ENV in go/go.mk)
>
> Signed-off-by: Patrick Gerber <pge at ik.me>
I slightly extended the commit log to explain why mender-artifacts had
that settings to begin with and applied to next, thanks.
Regards,
Yann E. MORIN.
> ---
> package/mender-artifact/mender-artifact.mk | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/package/mender-artifact/mender-artifact.mk b/package/mender-artifact/mender-artifact.mk
> index 1031166f34..6ade624a23 100644
> --- a/package/mender-artifact/mender-artifact.mk
> +++ b/package/mender-artifact/mender-artifact.mk
> @@ -86,14 +86,6 @@ HOST_MENDER_ARTIFACT_LICENSE_FILES = \
>
> HOST_MENDER_ARTIFACT_DEPENDENCIES = host-xz
>
> -# By default, go will attempt to download needed modules before building, which
> -# is not desirable. This behavior also causes permission issues when cleaning,
> -# as go downloads modules as read-only by default. Because mender-artifact
> -# includes the modules in the vendor directory, mod=vendor prevents the package
> -# from downloading the go modules during the build process and prevents
> -# permission issues when cleaning.
> -HOST_MENDER_ARTIFACT_GO_ENV = GOFLAGS="-mod=vendor"
> -
> HOST_MENDER_ARTIFACT_LDFLAGS = -X github.com/mendersoftware/mender-artifact/cli.Version=$(HOST_MENDER_ARTIFACT_VERSION)
>
> HOST_MENDER_ARTIFACT_BIN_NAME = mender-artifact
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list