[Buildroot] [PATCH 1/1] package/xenomai: always set default version
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Tue Aug 9 11:39:32 UTC 2022
On Mon, 8 Aug 2022 23:54:04 +0200
Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:
> Always set a default value for BR2_PACKAGE_XENOMAI_VERSION to avoid a
> build failure when BR2_PACKAGE_XENOMAI_VERSION is empty with
> BR2_PACKAGE_XENOMAI_CUSTOM_{GIT,VERSION}
>
> Fixes:
> - http://autobuild.buildroot.org/results/d80c295a848b5be69324f5dfbd269b046dc68e8c
> - http://autobuild.buildroot.org/results/4e57a499b43208e546dd962ca04b43408c0c082c
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
> package/xenomai/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> index ec6d9e5d29..5c179eec72 100644
> --- a/package/xenomai/Config.in
> +++ b/package/xenomai/Config.in
> @@ -73,8 +73,8 @@ config BR2_PACKAGE_XENOMAI_VERSION
> string "Custom Xenomai version" if \
> !BR2_PACKAGE_XENOMAI_LATEST_VERSION && \
> !BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
> - default "3.0.10" if BR2_PACKAGE_XENOMAI_LATEST_VERSION
> default "custom" if BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
> + default "3.0.10"
Meh, I don't like how Xenomai handles things differently than all other
packages that have a configurable version.
IMO, we should make Xenomai look like the other packages, which means:
- Dropping default "https://gitlab.denx.de/Xenomai/xenomai.git"
- Not have any default value for BR2_PACKAGE_XENOMAI_VERSION
We really want consistency on how this "custom version" thing is
handled.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
More information about the buildroot
mailing list