[Buildroot] [PATCH 2/2] package/imx-cst: new package
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Fri Apr 22 10:16:43 UTC 2022
Hello,
On Fri, 22 Apr 2022 12:09:00 +0200
Thomas Perrot <thomas.perrot at bootlin.com> wrote:
> > It looks like the only difference between 64 and 32 is in openssl
> > build
> > rule, and for x86 (host) targets only. We don't use this openssl rule
> > since we build host-openssl with our own rules. So maybe we can just
> > arbitrarily choose hard coded 'linux64'. It seems that
> > debian/Makefile
> > does that.
>
> Thanks for your review, I’m submitting a v3 with the OSTYPE variable
> hardcoded to linux64.
No, please don't. We're doing the build like this:
build:
$(MAKE) -C $(CST_CODE_PATH)/obj.$(OSTYPE) build
And code/cst/code/obj.linux32/Makefile contains:
COPTIONS += -m32
LDOPTIONS += -m32
while code/cst/code/obj.linux64/Makefile contains
COPTIONS += -m64
LDOPTIONS += -m64
And I can definitely see the -m64 being added in the compiler flags
when doing a build on a x86-64 host (run the build with VERBOSE=1, you
will see).
So if you use linux64 unconditionally, the CST binaries will be built
with -m64, even on 32-bit host machines => bad.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
More information about the buildroot
mailing list