[Buildroot] [PATCH 1/1] toolchain/toolchain-external: ensure BR2_TOOLCHAIN_EXTERNAL_PATH is set

[Arnout Vandecappelle]

On 02/04/2022 04:07, James Hilliard wrote:
> Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
> ---
>   toolchain/toolchain-external/pkg-toolchain-external.mk | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
> index 299b6008aa..8274ace980 100644
> --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> @@ -69,6 +69,9 @@ ifeq ($(BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD),y)
>   TOOLCHAIN_EXTERNAL_INSTALL_DIR = $(TOOLCHAIN_EXTERNAL_DOWNLOAD_INSTALL_DIR)
>   else
>   TOOLCHAIN_EXTERNAL_INSTALL_DIR = $(abspath $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_PATH)))
> +ifeq ($(TOOLCHAIN_EXTERNAL_INSTALL_DIR),)

  You also need a condition on BR2_TOOLCHAIN_EXTERNAL, otherwise it will always 
fail with an internal toolchain.

  You also need a condition on BR_BUILDING, otherwise the error is printed even 
in situations where an invalid configuration is allowed (e.g. 'make help').

  I added both to all 4 patches and applied to master, thanks.

  Regards,
  Arnout

> +$(error No external toolchain path set, check your BR2_TOOLCHAIN_EXTERNAL_PATH setting)
> +endif
>   endif
>   
>   ifeq ($(TOOLCHAIN_EXTERNAL_INSTALL_DIR),)