[Buildroot] [PATCH 1/2] package/qt5base: fix race with libxkbcommon

Peter Korsgaard peter at korsgaard.com
Mon Apr 4 12:30:10 UTC 2022


>>>>> "Quentin" == Quentin Schulz <foss+buildroot at 0leil.net> writes:

 > From: Quentin Schulz <quentin.schulz at theobroma-systems.com>
 > qt5wayland package currently has a bug if the xkbcommon Qt config is not
 > enabled which highlighted a race issues between qt5base, libxkbcommon
 > and qt5wayland.

 > qt5wayland has a dependency on libxkbcommon package if it's enabled.
 > qt5base only has a dependency on libxkbcommon if xcb support is to be
 > enabled.

 > If libxkbcommon package is built before qt5base, qt5base will detect it
 > during its configure step and enable the Qt config accordingly. This
 > will make it available to qt5wayland afterwards, even if xcb support is
 > not enabled in Buildroot Kconfig.

 > However, if qt5base is built before libxkbcommon is, qt5base will not
 > advertise support of xbcommon feature to qt5wayland (which will fail its
 > build because of a bug in the source code).

 > Since the package build order should not impact the outcome of the
 > build, let's explicit the dependency if and only if libxkbcommon package
 > is to be compiled at some point in time so that at least this feature is
 > not susceptible to races.

 > Cc: Quentin Schulz <foss+buildroot at 0leil.net>
 > Signed-off-by: Quentin Schulz <quentin.schulz at theobroma-systems.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list