[Buildroot] [PATCH 1/2] configs/qemu_aarch64_sbsa_defconfig: use ARM cortex a57

[Romain Naour]

Hi Dick,

Le 07/11/2021 à 22:25, D. Olsson a écrit :
> Hi Romain,
> 
> Resending my review because I didn't reply to all :)
> 
>> On 7 Nov 2021, at 20:29, Romain Naour <romain.naour at gmail.com> wrote:
>>
>> When booting with cortex-a53, qemu refuse to start with the following message
>> [1]:
>>
>>  qemu-system-aarch64: sbsa-ref: CPU type other than the built-in cortex-a57
>> not supported
> 
> Thanks for catching this! Looks like removal of a53 support is a fairly recent
> change in
> QEMU: https://github.com/qemu/qemu/commit/4f335a6381f83beb5d6ac0d3993514379454a99d#diff-8efb73c3e0dd9d7a13b0597a056b4cd8fa9d9250c7de8b1d3b538d07d98a8c50
> <https://github.com/qemu/qemu/commit/4f335a6381f83beb5d6ac0d3993514379454a99d#diff-8efb73c3e0dd9d7a13b0597a056b4cd8fa9d9250c7de8b1d3b538d07d98a8c50>

Thanks for the link! Indeed the a53 support has been removed since qemu 6.0.

I was surprised by having this issue, It's a good reason to enable the gitlab
runtime testing in the following patch.

Best regards,
Romain


> 
>> Use ARM cortex a57 as requested by Qemu.
>>
>> [1]
>> https://git.qemu.org/?p=qemu.git;a=commitdiff;h=64580903c2b3aee08d74d64e6248a313b246cb69
>>
>> Signed-off-by: Romain Naour <romain.naour at gmail.com>
>> Cc: Dick Olsson <hi at senzilla.io>
>> ---
>> board/qemu/aarch64-sbsa/readme.txt  | 2 +-
>> configs/qemu_aarch64_sbsa_defconfig | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/board/qemu/aarch64-sbsa/readme.txt
>> b/board/qemu/aarch64-sbsa/readme.txt
>> index 7935108ef1..b62947f55f 100644
>> --- a/board/qemu/aarch64-sbsa/readme.txt
>> +++ b/board/qemu/aarch64-sbsa/readme.txt
>> @@ -17,7 +17,7 @@ Run the emulation with:
>>
>>   qemu-system-aarch64 \
>>     -M sbsa-ref \
>> -    -cpu cortex-a53 \
>> +    -cpu cortex-a57 \
>>     -smp 4 \
>>     -m 1024 \
>>     -nographic \
>> diff --git a/configs/qemu_aarch64_sbsa_defconfig
>> b/configs/qemu_aarch64_sbsa_defconfig
>> index 0e1c799b4d..d1e0adadd1 100644
>> --- a/configs/qemu_aarch64_sbsa_defconfig
>> +++ b/configs/qemu_aarch64_sbsa_defconfig
>> @@ -1,6 +1,6 @@
>> # Architecture
>> BR2_aarch64=y
>> -BR2_cortex_a53=y
>> +BR2_cortex_a57=y
>>
>> # Toolchain
>> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
>> -- 
>> 2.31.1
> 
> Looks good!
> 
> Reviewed-by: Dick Olsson <hi at senzilla.io>
>