[Buildroot] [PATCH 2/2] configs/nezha_defconfig: new defconfig

[Giulio Benetti]

Hi Peter,

On 11/5/21 2:35 PM, Peter Korsgaard wrote:
>>>>>> "Giulio" == Giulio Benetti <giulio.benetti at benettiengineering.com> writes:
> 
> Hi,
> 
>   >> +image sdcard.img {
>   >> +    hdimage {
>   >> +    }
>   >> +
>   >> +    partition boot0-1 {
>   >> +        in-partition-table = "no"
>   >> +        image = "boot0_sdcard_sun20iw1p1.bin"
>   >> +        offset = 8192
> 
>   > Can you please use 8K here ^^^
> 
>   >> +    }
>   >> +
>   >> +    partition boot0-2 {
>   >> +        in-partition-table = "no"
>   >> +        image = "boot0_sdcard_sun20iw1p1.bin"
>   >> +        offset = 131072
> 
>   > 128K here etc.
> 
>   > I find it to be easier to read.
> 
> Ok. The "documentation" actually lists this in 512b sectors, but I don't
> think genimage has something nice to handle this:

For curiosity I've checked genimage documentation:
https://github.com/pengutronix/genimage/blob/master/README.rst

And I've found that in master branch there is also the 's suffix that is 
used exactly for sector size of 512. BUT it will be available on V15 and 
we have instead V14 and V15 is still not released :-/
Anyway it can be useful in the near future.

It's been introduced on 26 March with this commit:
https://github.com/pengutronix/genimage/commit/bcd7fa662d0fdfb7b15a340ff42721cacc29bec9

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> https://linux-sunxi.org/Allwinner_Nezha
> 
> 
>   > I would go for changing every .cfg file in Buildroot and submit a
>   > patchset for this to improve readibility. What do you all think about
>   > this?
> 
> Fine by me.
>